Warp cursor settings ignored until restart

Bug #1468388 reported by Sean Greenslade
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Low
Jon Neal

Bug Description

Running the latest BZR (5813) on Windows. The default setting for eeschema is to warp cursor to center on zoom. I disabled this option, which worked fine. However when I entered the library editor, the warping behavior remained. After fully exiting and re-opening eeschema, the library editor then obeyed the setting. Going the other way shows the same behavior; library editor seems to lock to the settings observed on first program load.

Related branches

Changed in kicad:
importance: Undecided → Low
Changed in kicad:
status: New → Confirmed
Revision history for this message
J. Morio Sakaguchi (morio-earth) wrote :

This behavior is because draw_panel.cpp reads that particular option when it is created and writes that option when it is destoryed.

1. So Eeschema is started and reads the option.
2. The option is changed (hasn't been saved to the main config because Eeschema's draw_panel.cpp hasn't been closed)
3. Library editor is opened and a new draw_panel is instanciated (reads the old config) and acts like the option is never changed.
4. Eeschema is closed (writes out the config when the draw_panel object is destoryed)
5. Eeschema is loaded and library editor is opened. The configuration change is observed in both.

I'm new to the code but will hopefully find a solution for this.

Revision history for this message
J. Morio Sakaguchi (morio-earth) wrote :

Since the library editor is now loaded as its own app, it should have its own zoom and center option.
The patch adds the option to the library editor dialog and saves and loads it to settings.

Revision history for this message
Jon Neal (reportingsjr) wrote :

Here is a patch that may fix the issue a little better. Instead of adding another preference for it in the library editor it is pushed to the lib editor window whenever that window is opened.

There are also four other UI options that weren't being loaded correctly AND the same issue is happening in pcbnew/footprint editor.

I submitted this to the mailing this so we'll see if it gets committed.

Changed in kicad:
assignee: nobody → Jon Neal (reportingsjr)
Changed in kicad:
status: Confirmed → Fix Committed
Jon Neal (reportingsjr)
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.