P&S Router doesn't handle pad offset (or rotations) in the online DRC while routing

[Martin Errenst]

Tested with r5290.
Steps to reproduce:
0. Switch to GAL mode, enable shove routing.
1. Choose a SMD pad with some tracks close (so you can shove them later), edit the pads properties: set "Shape offset X" to an valid value. Check if the pad "moved".
2. Enable track mode, try to shove the tracks towards the pad.
Outcome: Tracks will be shoved up to the point of the original pad position (without the offset). The online DRC while shoving doesn't check for this.
Expected behaviour: Stop when hitting the current position of the pad.

Additionally, the online DRC fails to handle rotated pads in the correct way (checked with a 45° rotation - looks like it uses the smallest extend of the pad, builds a square out of it and routes around this).

[Karl Zeilhofer (zeilhofer)]

I found a similar misbehaveour for oval through hole pads, which have an out of center drill hole.
I have draged a track towards such pads (highlighted) so one can see the consequence of the bug.

[Chris Pavlina (pavlina-chris)]

Still present in 5484.

Application: kicad
Version: (2015-03-06 BZR 5484)-product Release build
wxWidgets: Version 3.0.2 (debug,wchar_t,compiler with C++ ABI 1002,GCC 4.9.2,wx containers,compatible with 2.8)
Platform: Linux 3.18.6-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Boost version: 1.57.0
         USE_WX_GRAPHICS_CONTEXT=OFF
         USE_WX_OVERLAY=OFF
         KICAD_SCRIPTING=ON
         KICAD_SCRIPTING_MODULES=ON
         KICAD_SCRIPTING_WXPYTHON=ON
         USE_FP_LIB_TABLE=HARD_CODED_ON
         BUILD_GITHUB_PLUGIN=ON
         KICAD_USE_WEBKIT=OFF

[Dmitry Golovin (cyb3r)]

I suffer from this too.

[Dmitry Golovin (cyb3r)]

I use version 5530.

[Nick Østergaard (nickoe)]

I think this is an important bug to get fixed for the next release, hence I set the importance as high.

[Chris Pavlina (pavlina-chris)]

http://misc.c4757p.com/pns_offset_pad.mp4

[Chris Pavlina (pavlina-chris)]

Got it.

[Maciej Suminski (orsonmmz)]

Great! Thank you Chris, I committed your patch in 5808.

[Stefan Hamminga (stefanhamminga)]

Hi, great job on the fix! This bug is now marked 'fix-commited', but this specific report involves two different issues and only one of them is fixed.

The second issue is KiCad doesn't account for arbitrary rotation of pads (as I submitted as bug #1401610 and Dmitry as #1453335). Could one of the admins split this report or remove the duplicate mark on one of the above reports so this one can be closed, but the rotation issue stays open?

[Chris Pavlina (pavlina-chris)]

Indeed, the rotation issue is still here.

[Chris Pavlina (pavlina-chris)]

And now, it's not. :)

[Tomasz Wlostowski (twlostow)]

There is a proper patch for rotated pads by Mathias Grimmberger. I need to integrate it in the geometry library/P&S router. I'll do my best to get it pushed this week.

Tom

[Nick Østergaard (nickoe)]

I guess this is the mentioned patch: https://lists.launchpad.net/kicad-developers/msg17316.html

[Piotr Esden-Tempski (esden)]

Tested with the demo project from https://bugs.launchpad.net/kicad/+bug/1462162

The routing now works as expected and avoids the pads correctly. Thank you very much for fixing this! Really appreciate. :)