Kicad crashes after changing pad net name and undo in pcbnew

[miceuz]

I use BZR 4888 version of kicad.

To reproduce:
- open kicad
- open pcb in pcbnew
- hit 'E' on a pad
- change netname to GND
- press enter
- press Ctrl-Z for undo
- move the mouse pointer

Both pcbnew and kicad crash with segmentation fault.

[miceuz (mic-j)]

I use 64bit Linux. Kicad is built locally

[Maciej Suminski (orsonmmz)]

Hi miceuz,

I am not able to reproduce the bug. Can you confirm that it happens every time and/or on every board you load?

Regards,
Orson

[miceuz (mic-j)]

Yes, I can confirm it happens everytime on at least two board layouts. Will try on a different system now.

[Maciej Suminski (orsonmmz)]

It crashes in function Magnetize() (pcbnew/magnetic_track_functions.cpp:123) trying to access currItem, that is probably invalid as it have been changed by SwapData() function during undo operation (pcbnew/board_undo_redo.cpp:537).
The brute way is to call SetCurItem( NULL ) in undo/redo functions or check if the pointer that we are going to replace is stored as current item and if so - fix the current item pointer. I am going to leave the decision to the main developers.

[Nick Østergaard (nickoe)]

I cannot confirm this bug in 5392 in either the legacy render or GAL. Can OP verify?

[miceuz (mic-j)]

I can't reproduce it on 5402, so the ticked can be closed.