pcbnew: Edit module + "Change Module(s)" produces strange-looking characters

[madworm]

Place a module (footprint) and edit it.

Use "Change Module(s)" to replace that module with something else or for simplicity with itself.

The modification to the board works as expected, but the pop-up message looks weird. Some characters are replaced with funny looking boxes, sometimes Chinese characters.

Some settings (via radio buttons) produce different-looking pop-up messages by repeatedly doing the very same thing.

See the video ( https://www.youtube.com/watch?v=-KOIKn1VRwY ) and the attached screen-shot.

---

Application: Pcbnew
Version: (2013-09-17 BZR 4320)-product
Build: wxWidgets 2.8.12 (no debug,Unicode,compiler with C++ ABI 1002,GCC 4.7.2,STL containers,compatible with 2.6)
Platform: Linux 3.7.10-1.16-desktop x86_64, 64 bit, Little endian, wxGTK
Boost version: 1.54.0
         USE_WX_GRAPHICS_CONTEXT=OFF
         USE_WX_OVERLAY=OFF
         KICAD_SCRIPTING=OFF
         KICAD_SCRIPTING_MODULES=OFF
         KICAD_SCRIPTING_WXPYTHON=OFF

[Wayne Stambaugh (stambaughw)]

I couldn't duplicate this on Windows so it is a Linux and possibly OSX
issue. I'm sure it's an issue converting from std::string to wxString.
 I thought fixed all of the cases in the new FPID code where that
happens but obviously I missed at least one. I wont be able to look at
it until I get home this evening and have access to a Linux machine.

On 9/17/2013 11:44 AM, madworm wrote:
> Public bug reported:
>
> Place a module (footprint) and edit it.
>
> Use "Change Module(s)" to replace that module with something else or for
> simplicity with itself.
>
> The modification to the board works as expected, but the pop-up message
> looks weird. Some characters are replaced with funny looking boxes,
> sometimes Chinese characters.
>
> Some settings (via radio buttons) produce different-looking pop-up
> messages by repeatedly doing the very same thing.
>
> See the video ( https://www.youtube.com/watch?v=-KOIKn1VRwY ) and the
> attached screen-shot.
>
>
> ---
>
> Application: Pcbnew
> Version: (2013-09-17 BZR 4320)-product
> Build: wxWidgets 2.8.12 (no debug,Unicode,compiler with C++ ABI 1002,GCC 4.7.2,STL containers,compatible with 2.6)
> Platform: Linux 3.7.10-1.16-desktop x86_64, 64 bit, Little endian, wxGTK
> Boost version: 1.54.0
> USE_WX_GRAPHICS_CONTEXT=OFF
> USE_WX_OVERLAY=OFF
> KICAD_SCRIPTING=OFF
> KICAD_SCRIPTING_MODULES=OFF
> KICAD_SCRIPTING_WXPYTHON=OFF
>
> ** Affects: kicad
> Importance: Undecided
> Status: New
>
> ** Attachment added: "1.jpg"
> https://bugs.launchpad.net/bugs/1226670/+attachment/3825532/+files/1.jpg
>

[Lorenzo Marcantonio (l-marcantonio)]

> I thought fixed all of the cases in the new FPID code where that
> happens but obviously I missed at least one. I wont be able to look at
> it until I get home this evening and have access to a Linux machine.

Feels like it overruns in memory and sucks random bytes... hate that
things. Maybe a checked wx build would help (I get all things of
assertions in this way).

However I did some heavy module replacement in these days but nothing
popped up on Linux (neither I've seen the issue)

--
Lorenzo Marcantonio
Logos Srl

[Dick Hollenbeck (dickelbeck)]

Maybe a "make clean" was needed before this build?

Did you build it yourself? If so, try a make clean first, if you did not previously.

[Wayne Stambaugh (stambaughw)]

On 9/17/2013 1:51 PM, Lorenzo Marcantonio wrote:
>> I thought fixed all of the cases in the new FPID code where that
>> happens but obviously I missed at least one. I wont be able to look at
>> it until I get home this evening and have access to a Linux machine.
>
> Feels like it overruns in memory and sucks random bytes... hate that
> things. Maybe a checked wx build would help (I get all things of
> assertions in this way).
>
> However I did some heavy module replacement in these days but nothing
> popped up on Linux (neither I've seen the issue)
>

What version of wxWidgets are you using? The bug report was filed
against 2.8.12. If you are using the 2.9 branch of wxWidgets, that's
probably why you are not seeing the problem. I think I already have it
fixed, but I'll wait until I can test it this evening before I commit
the fix.

[Lorenzo Marcantonio (l-marcantonio)]

On Tue, Sep 17, 2013 at 07:30:43PM -0000, Wayne Stambaugh wrote:
> What version of wxWidgets are you using? The bug report was filed
> against 2.8.12. If you are using the 2.9 branch of wxWidgets, that's
> probably why you are not seeing the problem. I think I already have it

Yep, 2.9.4 here. wxString strikes again, I suppose...

--
Lorenzo Marcantonio
Logos Srl

[Dick Hollenbeck (dickelbeck)]

On Sep 17, 2013 8:40 PM, "Wayne Stambaugh" <email address hidden>
wrote:
>
> ** Changed in: kicad
> Importance: Undecided => High
>
> ** Changed in: kicad
> Assignee: (unassigned) => Wayne Stambaugh (stambaughw)
>
> ** Changed in: kicad
> Status: New => Confirmed

See if it happens in the debug build. If not then I think I've seen this
before. Something to do with printf () ing a wxstring back into itself,
which does not work in 2.8 release builds, but does in debug builds.

>
> --
> You received this bug notification because you are a member of KiCad Bug
> Squad, which is subscribed to KiCad.
> https://bugs.launchpad.net/bugs/1226670
>
> Title:
> pcbnew: Edit module + "Change Module(s)" produces strange-looking
> characters
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1226670/+subscriptions

[Wayne Stambaugh (stambaughw)]

Fix committed in r4322. As I expected, tt was the conversion from std::string to wxString that was causing the problem. Let me know if you find any other occurrences of this.