Inconsistency between confirmation dialogs

[Jacobo Aragunde Pérez]

Reported at users mailing list:

While working on a rather large schematic and pcb, i noticed that there
is no consistency in the dialogs concerning closing windows.

EEschema and PCBnew have a nice ones:
"Schematic/PCB modified. Save before exit?" [ No ] [ Cancel ] [[ Yes ]]

very clear.

unfortunately the Module editor throws me in the dark:
"Module modified! Continue? [ No ] [[ Yes ]]

it is not clear if my work will be saved or not before close. my guess
is that it doesnt.

the Library editor has a inverted approach, it oes NOT save by default:

"Component was modified! Discart changes? [ No ] [[ Yes ]]

I'm on kicad 2012-11-02 on Ubuntu 12.10

[Jacobo Aragunde Pérez (jaragunde)]

This patch replaces the existing dialogs in the library and module editors with the application-wide exit confirmation dialog.

I had to modify LIB_EDIT_FRAME::SaveActiveLibrary to return a boolean value, so we can stop the exit process in case the user wanted to save but an error happens. I added a function called LIB_EDIT_FRAME::OnSaveActiveLibrary to act as the wxWidgets event handler (it must be a function returning void).

I'm not completely satisfied with the solution for the library editor, as there are two types of confirmation dialogs, one for the changes on the component itself and another one for the changes on libraries. I've left the library confirmation dialog as it was, at least for now. A general rework of the saving process would be needed, since it looks too complicated and shows too many confirmation dialogs, but that's work for another day ;)

[Martin Errenst (imp-d)]

r3934 stable