Audit middleware does not work with APIs which does not require a Keystone token

[Guang Yee]

Audit middleware assumes the existence of Keystone token and therefore the existence of the identity headers (i.e. HTTP_X_USER_ID, HTTP_X_USER_NAME) in the headers.

https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/audit.py#L400

Some Swift APIs (i.e. list publically available containers) does not required a Keystone token, and therefore the identity headers will not be populated.

Audit middleware should consider the following:

1. do not emit an audit event if Keystone token is not present in the request, or
2. come up with a generic/common way to audit these types of requests

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/320725

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/320725
Committed: https://git.openstack.org/cgit/openstack/keystonemiddleware/commit/?id=d8cb5a3e9339a67aab13c2af31bfbff39b14fbc6
Submitter: Jenkins
Branch: master

commit d8cb5a3e9339a67aab13c2af31bfbff39b14fbc6
Author: Guang Yee <email address hidden>
Date: Tue May 24 17:24:47 2016 -0700

    Make sure audit can handle API requests which does not require a token

    Some service APIs such as Swift list public containers does not require
    a token. Therefore, there will be no identity or service catalog information
    available. In these cases, audit should fill in the default
    (i.e. taxonomy.UNKNOWN) for both initiator and target instead of raising an
    exception.

    Change-Id: I3f3c12d5e8c0fa176fb7f0218c368971e0a9d0b5
    Closes-Bug: 1583699

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/keystonemiddleware 4.6.0 release.