Documentation for how to run tests is out of date

Bug #1550068 reported by Brad Pokorny
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
keystonemiddleware
Fix Released
Low
Brad Pokorny

Bug Description

The documentation for how to run tests for keystonemiddleware is out of date:

http://docs.openstack.org/developer/keystonemiddleware/

Running the tests with "python setup.py test" results in a bunch of errors:

ImportError: Failed to import test module: keystonemiddleware.tests.unit.test_s3_token_middleware
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/unittest2/loader.py", line 456, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/local/lib/python2.7/dist-packages/unittest2/loader.py", line 395, in _get_module_from_name
    __import__(name)
  File "keystonemiddleware/tests/unit/test_s3_token_middleware.py", line 16, in <module>
    from oslo_serialization import jsonutils
  File "/usr/local/lib/python2.7/dist-packages/oslo_serialization/jsonutils.py", line 42, in <module>
    from oslo_utils import timeutils
  File "/usr/local/lib/python2.7/dist-packages/oslo_utils/timeutils.py", line 25, in <module>
    from debtcollector import removals
  File "/usr/local/lib/python2.7/dist-packages/debtcollector/removals.py", line 19, in <module>
    import wrapt
ImportError: No module named wrapt
Ran 16 (-326) tests in 0.116s (-11.236s)
FAILED (id=4, failures=16 (+16))
error: testr failed (1)

Running with tox currently gets them to pass on the master branch.

Brad Pokorny (bpokorny)
Changed in keystonemiddleware:
assignee: nobody → Brad Pokorny (bpokorny)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystonemiddleware (master)

Fix proposed to branch: master
Review: https://review.openstack.org/284997

Changed in keystonemiddleware:
status: New → In Progress
Changed in keystonemiddleware:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystonemiddleware (master)

Reviewed: https://review.openstack.org/284997
Committed: https://git.openstack.org/cgit/openstack/keystonemiddleware/commit/?id=05a20bbc95c3fa1b20f6beb88e1b29588f9af8ed
Submitter: Jenkins
Branch: master

commit 05a20bbc95c3fa1b20f6beb88e1b29588f9af8ed
Author: Brad Pokorny <email address hidden>
Date: Thu Feb 25 16:50:34 2016 -0800

    Update documentation for running tests

    The documentation for how to run tests currently says to use
    "python setup.py test", which results in errors. Update the docs
    to specify tox.

    Change-Id: Ib32f6c0708de9439b6bdee4a4fb56cb88bc47d5a
    Closes-Bug: #1550068

Changed in keystonemiddleware:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/keystonemiddleware 4.5.0

This issue was fixed in the openstack/keystonemiddleware 4.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.