Keystonemiddleware should switch to oslo.cache

Bug #1523375 reported by Davanum Srinivas (DIMS)
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
keystonemiddleware
Fix Released
Low
Jaewoo Park

Bug Description

Keystone has moved to oslo.cache in https://review.openstack.org/#/c/195873/ we should use oslo.cache for middleware as well.

Boris Bobrov (bbobrov)
Changed in keystonemiddleware:
assignee: nobody → Boris Bobrov (bbobrov)
Changed in keystonemiddleware:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to keystonemiddleware (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/268662

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/268663

Changed in keystonemiddleware:
assignee: Boris Bobrov (bbobrov) → Jamie Lennox (jamielennox)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystonemiddleware (master)

Fix proposed to branch: master
Review: https://review.openstack.org/268664

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystonemiddleware (master)

Change abandoned by Jamie Lennox (<email address hidden>) on branch: master
Review: https://review.openstack.org/268663

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to keystonemiddleware (master)

Reviewed: https://review.openstack.org/268662
Committed: https://git.openstack.org/cgit/openstack/keystonemiddleware/commit/?id=f54ff06c1f5e274ea31ffac5faf1f57557fe586a
Submitter: Jenkins
Branch: master

commit f54ff06c1f5e274ea31ffac5faf1f57557fe586a
Author: Jamie Lennox <email address hidden>
Date: Wed Feb 17 17:50:25 2016 +1100

    Handle cache invalidate outside cache object

    Move the logic that handles invalid cache entries out of the cache
    object itself. This makes the cache interface more normal and will make
    it easier to convert to oslo.cache later.

    Rename the store method to set because this is the interface that
    oslo.cache uses.

    Related-Bug: #1523375
    Change-Id: Ia7b11a69f14e17a9d7a36c009d9a965be16509d0

Revision history for this message
Lance Bragstad (lbragstad) wrote :

Automatically unassigning due to inactivity.

Changed in keystonemiddleware:
assignee: Jamie Lennox (jamielennox) → nobody
David Stanek (dstanek)
Changed in keystonemiddleware:
status: In Progress → Confirmed
Revision history for this message
Lance Bragstad (lbragstad) wrote :

This was discussed during the keystone meeting this week [0] since it related to a python 3 discussion.

I had an action item to propose a keystonemiddleware spec to detail the work, but since this bug report exists, we can keep the conversation here.

[0] http://eavesdrop.openstack.org/meetings/keystone/2017/keystone.2017-03-21-18.00.log.html#l-136

Changed in keystonemiddleware:
assignee: nobody → Nicolas Helgeson (nhelgeson)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystonemiddleware (master)

Fix proposed to branch: master
Review: https://review.openstack.org/513862

Changed in keystonemiddleware:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystonemiddleware (master)

Change abandoned by Nicolas Helgeson (<email address hidden>) on branch: master
Review: https://review.openstack.org/513862
Reason: merged with https://review.openstack.org/#/c/268664/

Changed in keystonemiddleware:
assignee: Nicolas Helgeson (nhelgeson) → Jaewoo Park (aselius)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystonemiddleware (master)

Reviewed: https://review.openstack.org/268664
Committed: https://git.openstack.org/cgit/openstack/keystonemiddleware/commit/?id=9d8e2836fe7fca186e0380d8a532540ff5cc5215
Submitter: Zuul
Branch: master

commit 9d8e2836fe7fca186e0380d8a532540ff5cc5215
Author: Jamie Lennox <email address hidden>
Date: Sun Jan 17 00:34:02 2016 +1100

    Use oslo_cache in auth_token middleware

    Use the new oslo.cache library instead of using memcached directly.
    This keeps the old options around and will continue to use those in
    preference to the oslo.config library as there is no way to test whether
    oslo.cache was explicitly configured to use that in preference.

    Currently there are no messages or anything to deprecate the old options
    until we've had a chance to test it in production environments.

    Closes-Bug: #1523375
    Change-Id: Ifccacc5db311ad538ce60191cbe221644d1a5807
    Co-Authored-By: Nicolas Helgeson <email address hidden>

Changed in keystonemiddleware:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystonemiddleware 4.19.0

This issue was fixed in the openstack/keystonemiddleware 4.19.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers