v3 to v2 catalog conversion missing id

[Matthew Edmonds]

the keystonemiddleware.auth_token._v3_to_v2_catalog() method is dropping the id portion of the catalog during the conversion. This breaks the pycadf audit middleware, as seen in the following trace, and may also have other impacts.

2015-02-11 03:13:46.917 15544 ERROR pycadf.middleware.notifier [req-97bd23d9-61eb-43c2-8171-a93e74303e8d None] An exception occurred processing the API call: 'id'
2015-02-11 03:13:46.917 15544 TRACE pycadf.middleware.notifier Traceback (most recent call last):
2015-02-11 03:13:46.917 15544 TRACE pycadf.middleware.notifier File "/usr/lib/python2.7/site-packages/pycadf/middleware/notifier.py", line 36, in wrapped
2015-02-11 03:13:46.917 15544 TRACE pycadf.middleware.notifier return fn(*args, **kwargs)
2015-02-11 03:13:46.917 15544 TRACE pycadf.middleware.notifier File "/usr/lib/python2.7/site-packages/pycadf/middleware/audit.py", line 35, in process_request
2015-02-11 03:13:46.917 15544 TRACE pycadf.middleware.notifier self.cadf_audit.append_audit_event(request)
2015-02-11 03:13:46.917 15544 TRACE pycadf.middleware.notifier File "/usr/lib/python2.7/site-packages/pycadf/audit/api.py", line 282, in append_audit_event
2015-02-11 03:13:46.917 15544 TRACE pycadf.middleware.notifier event = self.create_event(req, correlation_id)
2015-02-11 03:13:46.917 15544 TRACE pycadf.middleware.notifier File "/usr/lib/python2.7/site-packages/pycadf/audit/api.py", line 240, in create_event
2015-02-11 03:13:46.917 15544 TRACE pycadf.middleware.notifier service_info = self._get_service_info(default_endpoint)
2015-02-11 03:13:46.917 15544 TRACE pycadf.middleware.notifier File "/usr/lib/python2.7/site-packages/pycadf/audit/api.py", line 188, in _get_service_info
2015-02-11 03:13:46.917 15544 TRACE pycadf.middleware.notifier id=identifier.norm_ns(endp['endpoints'][0]['id']),
2015-02-11 03:13:46.917 15544 TRACE pycadf.middleware.notifier KeyError: 'id'
2015-02-11 03:13:46.917 15544 TRACE pycadf.middleware.notifier

[wanghong (w-wanghong)]

I think this bug has been fixed: https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/audit.py#L189

[Matthew Edmonds (edmondsw)]

The fix referenced in the previous comment is for a different middleware (audit vs. auth_token). This does not appear to have been addressed yet in the auth_token middleware. See https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py#L416

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/164826

[Steve Martinelli (stevemar)]

Can you try using the latest pycadf (0.8.0) and latest keystonemiddleware (1.50)? This should have been resolved by now.
The pycadf library's middleware component has been deprecated, and moved into keystonemiddleware.

For info on configuring the audit middleware: http://docs.openstack.org/developer/keystonemiddleware/audit.html

[Matthew Edmonds (edmondsw)]

I haven't seen that trace after upgrading pycadf and keystonemiddleware. But I still think the proposed change is beneficial... other things could need the id on a v3 to v2 conversion.

And I'm still having to use the deprecated pycadf audit middleware, because I can't get the one in keystonemiddleware to work. Separate issue...

[Steve Martinelli (stevemar)]

pycadf's audit middleware addressed this issue

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matthew Edmonds (<email address hidden>) on branch: master
Review: https://review.openstack.org/164826
Reason: Not sure this is needed anymore, so it doesn't seem to make sense to waste time debating whether it's correct or not.