Token binding can't work with a Service Token

Bug #1413433 reported by Jamie Lennox
256
This bug affects 1 person
Affects Status Importance Assigned to Milestone
keystonemiddleware
Fix Released
Medium
Colleen Murphy

Bug Description

The service token is used in conjunction with the user's token when a service is communicating with another service on behalf of a client.

When auth_token middleware validates token binding it validates both the X-Auth-Token and the X-Service-Token. This is pretty much impossible as there is no realistic configuration where the service has the bind credentials for the user token and it's own service token.

When auth_token recieves a X-Auth-Token AND an X-Service-Token it should only validate the bind of the X-Service-Token as this is where this request has originated.

Changed in keystonemiddleware:
importance: Undecided → Medium
status: New → Triaged
jiaxi (tjxiter)
Changed in keystonemiddleware:
assignee: nobody → jiaxi (tjxiter)
jiaxi (tjxiter)
Changed in keystonemiddleware:
assignee: jiaxi (tjxiter) → nobody
information type: Public → Public Security
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystonemiddleware (master)

Fix proposed to branch: master
Review: https://review.openstack.org/304400

Changed in keystonemiddleware:
assignee: nobody → Colleen Murphy (krinkle)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystonemiddleware (master)

Reviewed: https://review.openstack.org/304400
Committed: https://git.openstack.org/cgit/openstack/keystonemiddleware/commit/?id=5ba835f3e145e7ec3e71beabaf8711244159dc37
Submitter: Jenkins
Branch: master

commit 5ba835f3e145e7ec3e71beabaf8711244159dc37
Author: Colleen Murphy <email address hidden>
Date: Mon Apr 11 19:13:56 2016 -0700

    Only confirm token binding on one token

    When using service tokens and kerberos, the REMOTE_USER will be the
    service user, and hence the token bind confirmation will always fail to
    validate the client user's token, making it impossible to use token
    binding with service tokens. This patch adds a test to expose the issue
    and fixes the problem by only validating the token binding for the
    service token when both tokens are in the request.

    Change-Id: I7ba2283e8e58b89f1e42bc738c7e77284321e3a5
    Closes-bug: #1413433

Changed in keystonemiddleware:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/keystonemiddleware 4.5.0

This issue was fixed in the openstack/keystonemiddleware 4.5.0 release.

To post a comment you must log in.
This report contains Public Security information  
Everyone can see this security related information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.