'invalid' tokens redundantly remarked as 'invalid'

[Peter Feiner]

When the WSGI middleware in keystoneclient rejects a token because it's marked as 'invalid' in the cache, the middleware redundantly re-marks the token as 'invalid' in the cache. These redundant invalidations make debugging the original cause for the token being marked invalid difficult because each invalidation adds spam to log files. I've attached a patch that eliminates the redundant invalidation.

[Matt Fischer (mfisch)]

Peter,

You'll need to submit this through gerritt for it to get any attention:
https://wiki.openstack.org/wiki/Gerrit_Workflow

[Brant Knudson (blk-u)]

https://review.openstack.org/#/c/96786/ should take care of this.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Brant Knudson (<email address hidden>) on branch: master
Review: https://review.openstack.org/96786
Reason: Moved to keystonemiddleware -- https://review.openstack.org/102399

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/114848

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/114848
Committed: https://git.openstack.org/cgit/openstack/keystonemiddleware/commit/?id=7c954516f52761596aa39c5a7f5ed7b25ec0eacd
Submitter: Jenkins
Branch: master

commit 7c954516f52761596aa39c5a7f5ed7b25ec0eacd
Author: Brant Knudson <email address hidden>
Date: Sun Aug 17 16:34:33 2014 -0500

    Add a test for re-caching a token

    There was no test that showed that when a token was in the cache
    and a request is made to validate it again, it gets cached again.

    Change-Id: I1992fa6b5ddc0792dfd1ce90fb888c365ecb1612
    Partial-Bug: #1289075

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/102399
Committed: https://git.openstack.org/cgit/openstack/keystonemiddleware/commit/?id=40a2d48ba48aa3d38bed590dbc135d83553a9314
Submitter: Jenkins
Branch: master

commit 40a2d48ba48aa3d38bed590dbc135d83553a9314
Author: Brant Knudson <email address hidden>
Date: Sun Aug 17 12:58:35 2014 -0500

    auth_token cached token handling

    auth_token handles tokens that are from its cache, uncached PKI
    (compressed and ASN, "offline validation") and UUID/hashed tokens
    ("online" validation).

    For all of these cases, the auth_token middleware was doing

    1) expiration check
    2) confirm token bind
    3) store in cache

    In some cases, some of these steps aren't necessary.

    When getting the token from the cache
    1) no expiration check is needed because the expiration time is
       stored as cache data and the token would be rejected during
       _cache_get.
    2) Storing in the cache is unnecessary because the token is
       already in the cache.

    When doing online validation, it's not necessary to do the
    expiration check because the identity server would have rejected
    the token if it was expired.

    Closes-Bug: #1289075
    Change-Id: I6afa98504215521538434f1f8a2d97585ce35de5