Misuse of asserTrue

Bug #1988668 reported by Takashi Natsume
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Fix Released
Undecided
Takashi Natsume
keystoneauth
New
Undecided
Takashi Natsume

Bug Description

There are some misuse of assertTrue in the following files
in master (commit b05b27c0b63cf350702a094a4ca112e850926a91).

test/unit/common/test_db.py:424
        self.assertTrue(info['status_changed_at'], status_changed_at)

test/unit/common/test_manager.py:1026
                self.assertTrue(os.path.exists, os.path.join(t, f))
test/unit/common/test_manager.py:1649
                self.assertTrue(pids, expected)

test/unit/common/test_storage_policy.py:759
        self.assertTrue(policies[0].name, 'Policy-0')

Changed in swift:
assignee: nobody → Takashi Natsume (natsume-takashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/swift/+/855816

Changed in swift:
status: New → In Progress
summary: - Fix misuse of asserTrue
+ Misuse of asserTrue
Changed in keystoneauth:
assignee: nobody → Takashi Natsume (natsume-takashi)
Revision history for this message
Takashi Natsume (natsume-takashi) wrote :

keystoneauth(master, commit aa9c5d230f48c0ca4a4fb5dde6c92a07aab287e0)

keystoneauth1/tests/unit/identity/test_identity_common.py:1407
        self.assertTrue(data.url, self.TEST_COMPUTE_PUBLIC + '/v2.1')

keystoneauth1/tests/unit/loading/test_fixtures.py:86
        self.assertTrue(token, m.last_request.headers['X-Auth-Token'])

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.opendev.org/c/openstack/swift/+/855816
Committed: https://opendev.org/openstack/swift/commit/3e6650f99ea1bdf2c64df5ac8554db2feb3f8ee4
Submitter: "Zuul (22348)"
Branch: master

commit 3e6650f99ea1bdf2c64df5ac8554db2feb3f8ee4
Author: Takashi Natsume <email address hidden>
Date: Sun Sep 4 20:00:58 2022 +0900

    Fix misuse of assertTrue

    Replace assertTrue with assertEqual.
    Fix calling os.path.exists.

    Change-Id: I745df5af4f6a1fadb73c54b8ee31abfbda335fc4
    Closes-Bug: 1988668
    Signed-off-by: Takashi Natsume <email address hidden>

Changed in swift:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/swift 2.31.0

This issue was fixed in the openstack/swift 2.31.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.