Register deprecated opts with Adapter.get_conf_options

Bug #1708673 reported by Eric Fried
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
keystoneauth
Fix Released
Undecided
Eric Fried

Bug Description

keystoneauth1.loading.session.Session.get_conf_options has a deprecated_opts kwarg to register deprecated options such that, if you're replacing an existing (usually non-ksa) option with one from ksa Session, you can associate a DeprecatedOpt with the ksa Session opt.

keystoneauth1.loading.adapter.Adapter.get_conf_options doesn't have this facility.

There is demand for this function in the efforts of running endpoint/version discovery consistently through ksa. For example, the nova work for blueprint use-service-catalog-for-endpoints needs to be able to deprecate [ironic]api_endpoint in favor of Adapter's endpoint_override option.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystoneauth (master)

Fix proposed to branch: master
Review: https://review.openstack.org/490895

Changed in keystoneauth:
assignee: nobody → Eric Fried (efried)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystoneauth (master)

Reviewed: https://review.openstack.org/490895
Committed: https://git.openstack.org/cgit/openstack/keystoneauth/commit/?id=aeb38d5d08dcad076c1e751ae108774bfb886c53
Submitter: Jenkins
Branch: master

commit aeb38d5d08dcad076c1e751ae108774bfb886c53
Author: Eric Fried <email address hidden>
Date: Fri Aug 4 09:53:53 2017 -0500

    Adapter.get_conf_options(deprecated_opts)

    Support a deprecated_opts dict kwarg to
    keystoneauth1.loading.adapter.Adapter.get_conf_options that behaves just
    like the one for keystoneauth1.loading.session.Session.get_conf_options

    Ditto register_conf_options.

    Change-Id: I40b568c1b8570b349def0a966526ed4515d08105
    Closes-Bug: #1708673

Changed in keystoneauth:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystoneauth 3.2.0

This issue was fixed in the openstack/keystoneauth 3.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.