get_adapter_conf_options(include_deprecated=False) results in NoSuchOptError

Bug #1707273 reported by Eric Fried
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
keystoneauth
Fix Released
Undecided
Eric Fried

Bug Description

If you keystoneauth1.loading.get_adapter_conf_options with the new [1] include_deprecated kwarg set to False, you get a list of opts that excludes 'interface'.

If you then register these opts, and then attempt to keystoneauth1.loading.load_adapter_from_conf_options, you'll get "NoSuchOptError: no such option interface in group [whatever]".

This is because the loading code expects the interface opt to be present [2] [3].

[1] https://github.com/openstack/keystoneauth/commit/81363eca7903c2dc01d39b4c1569a6750ff13502
[2] https://github.com/openstack/keystoneauth/commit/81363eca7903c2dc01d39b4c1569a6750ff13502#diff-17c9a323cdd325fecd29d547d4c2e459R172
[3] https://github.com/openstack/keystoneauth/commit/81363eca7903c2dc01d39b4c1569a6750ff13502#diff-17c9a323cdd325fecd29d547d4c2e459R183

Changed in keystoneauth:
assignee: nobody → Eric Fried (efried)
status: New → In Progress
Revision history for this message
Eric Fried (efried) wrote :
Changed in keystoneauth:
assignee: Eric Fried (efried) → nobody
Changed in keystoneauth:
assignee: nobody → Eric Fried (efried)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystoneauth (master)

Reviewed: https://review.openstack.org/488568
Committed: https://git.openstack.org/cgit/openstack/keystoneauth/commit/?id=81ec69116a5252c1f90c0a1742f88b409851b0a8
Submitter: Jenkins
Branch: master

commit 81ec69116a5252c1f90c0a1742f88b409851b0a8
Author: Monty Taylor <email address hidden>
Date: Fri Jul 28 13:45:25 2017 -0500

    Protect against missing interface attribute

    If deprecated options aren't registered, interface will not exist,
    resulting in NoSuchOptError.

    Add safeguards around accessing the interface opt, and appropriate test
    cases.

    Co-Authored-By: Eric Fried <email address hidden>
    Closes-Bug: #1707273
    Change-Id: Ic3df9817f0038f8f610db70d7e34fe9d458606b6

Changed in keystoneauth:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystoneauth 3.2.0

This issue was fixed in the openstack/keystoneauth 3.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.