fails to log auth headers, request logging incomplete

[John Dennis]

If you enable debug logging the logging of requests performed by Session._http_log_request() in keystoneauth/keystoneauth1/session.py omits any modification of the request by the request auth callback.

Session.request does this:

        if requests_auth:
            kwargs['auth'] = requests_auth

just before calling self._http_log_request()

In the case of SAML ECP the requests_auth callback is:

keystoneauth1.extras._saml2.v3.saml2._SamlAuth

which modifies the request headers, but the auth callback is not invoked until send() is called which is after the request is logged. The net result is the headers set the by the auth callback are missing from the logged request making it look as if the request is malformed.

The logging should either be performed at the moment the request is emitted by python-requests (not sure but there may be a hook for this) or after the request returns.

[Lance Bragstad (lbragstad)]

Automatically unassigning due to inactivity.