auth_token emits deprecation warning for keystoneclient

[Jamie Lennox]

AuthToken middleware is emitting log warnings like:

UserWarning: Using keystoneclient sessions has been deprecated. Please update your software to use keystoneauth1.

This warning was added as part of https://review.openstack.org/#/c/387733/ to make sure users were passing keystoneauth sessions to keystoneauth libraries and not the older keystoneclient sessions.

Unfortunately this misses a hack we do in auth_token middleware where we build an adapter and pass the whole adapter as a session. This works because the relied on interface is designed to exactly match. Really this is a strange situation and we shouldn't be passing adapters around like this but it's a much larger fix to auth_token middleware to change this that doesn't have a functionality difference.

We should fix this in keystoneauth to allow this recursive adapter situation, as really all we care about in this check is that users aren't mixing keystoneclient and keystoneauth.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/406647

[Jamie Lennox (jamielennox)]

Filing against keystonemiddleware because this is where people will likely encounter the problem. We should really fix keystonemiddleware to not nest the adapters like this.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/406647
Committed: https://git.openstack.org/cgit/openstack/keystoneauth/commit/?id=c5bac3a32c6a48a1f81e242638e586749a1f514b
Submitter: Jenkins
Branch: master

commit c5bac3a32c6a48a1f81e242638e586749a1f514b
Author: Jamie Lennox <email address hidden>
Date: Mon Dec 5 11:03:20 2016 +1100

    Don't issue deprecation warning when nesting adapters

    Auth token middleware does a bit of a hack where it passes an Adapter in
    as a session to the client. This is useful there because we need to know
    much more about the authentication information than we do in most
    clients.

    We should look at fixing this in auth_token middleware, however for now
    we shouldn't issue a deprecation warning when a user passes an Adapter
    as a session object because this has always been designed to work - just
    not something we recommend.

    Change-Id: If7ebe59d5908275e607f32244027c8e6f3d1e157
    Closes-Bug: #1647230

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/keystoneauth 2.17.0 release.

[Morgan Fainberg (mdrnstm)]

Is this still an issue for ksm?