get_endpoint returns URL where it should return None

[Jamie Lennox]

When you call get_endpoint on an auth plugin and no endpoint is available it is supposed to return None. With the patch [1] we do a urljoin() to allow for relative endpoints to be joined with the url that the discovery request was made to. This concept is fine but if you urljoin the expected None return value with the url urljoin returns the original url.

eg urljoin('http://example.com', None) == 'http://example.com'

Because we always urljoin when doing version discovery this means that a URL is always being returned ever when one shouldn't be. This is breaking keystonemiddleware and anything else doing proper version discovery.

[1] https://review.openstack.org/#/c/356808/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/360209

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/360209
Committed: https://git.openstack.org/cgit/openstack/keystoneauth/commit/?id=b7b887c5192f2940073d038360a64041fc4f38cc
Submitter: Jenkins
Branch: master

commit b7b887c5192f2940073d038360a64041fc4f38cc
Author: Jamie Lennox <email address hidden>
Date: Thu Aug 25 13:49:35 2016 +1000

    get_endpoint should return None when no version found

    After patch Ia08538ccf00c9063dc0d284c5ece9a969c15500a the urljoin would
    ensure that a URL was always returned from the get_endpoint method even
    when the version was not available. This breaks plugin discovery and a
    number of other areas.

    Change-Id: I04014b6e770c2e9708c5f9c81c3160d51603ad0c
    Closes-Bug: #1616720

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/keystoneauth 2.12.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/keystoneauth 2.12.1 release.