Extras authentication plugins do not register entry_points

Bug #1567260 reported by Sören Bleikertz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
keystoneauth
Fix Released
Critical
Dolph Mathews

Bug Description

The "extras" plugins like kerberos and saml do not register under setup.cfg entry_points. Thus they are not picked up by the ExtensionManager when loading all available plugins for the keystoneauth1.plugin namespace.

Changed in keystoneauth:
importance: Undecided → Critical
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystoneauth (master)

Fix proposed to branch: master
Review: https://review.openstack.org/321814

Changed in keystoneauth:
assignee: nobody → Colleen Murphy (krinkle)
status: Triaged → In Progress
Changed in keystoneauth:
assignee: Colleen Murphy (krinkle) → Steve Martinelli (stevemar)
Changed in keystoneauth:
assignee: Steve Martinelli (stevemar) → Colleen Murphy (krinkle)
Changed in keystoneauth:
assignee: Colleen Murphy (krinkle) → Jamie Lennox (jamielennox)
Changed in keystoneauth:
assignee: Jamie Lennox (jamielennox) → Dolph Mathews (dolph)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystoneauth (master)

Reviewed: https://review.openstack.org/321814
Committed: https://git.openstack.org/cgit/openstack/keystoneauth/commit/?id=fc95d25544a0f14e886810ab53c689909b22cad9
Submitter: Jenkins
Branch: master

commit fc95d25544a0f14e886810ab53c689909b22cad9
Author: Colleen Murphy <email address hidden>
Date: Thu May 26 12:01:59 2016 -0700

    Make the kerberos plugin loadable

    This patch adds a BaseLoader class for the Kerberos plugin and an entry
    point in setup.cfg.

    Since the plugin file is being renamed, also fix the comment that
    refers to the library as 'keystoneauth' - it is called 'keystoneauth1'
    and trying to install 'keystoneauth' will cause the outdated version of
    the library to be installed and kerberos will not work.

    To make sure the plugin was loadable, this was tested using a version
    of python-openstackclient that had been migrated to keystoneauth[1].

    [1] https://review.openstack.org/#/c/276350/

    Change-Id: Id339295c795f6bf1b428dac8fc9f79d2f5fb453f
    Closes-bug: #1567257
    Partial-bug: #1567260

Revision history for this message
Steve Martinelli (stevemar) wrote :

We now have a framework for handling plugins that require "extra" libraries. We have entrypoints for OAuth, Kerberos, and SAML. The only one missing is ADFS which can be completed in another bug report.

Changed in keystoneauth:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.