keystoneauth

TCP defaults not supported on OSX

Bug #1522046 reported by jbehling on 2015-12-02

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	keystoneauth	Invalid	Wishlist	Unassigned

Bug Description

on OSX sockets do not support the TCP_KEEPCNT and TCP_KEEPINTVL options. When keystone auth attempts to set defaults it fails with 'module' object has no attribute.

For "keep-idle" there is already a conditional that checks whether the socket object supports the option before setting it. In the attached patch I extend that conditional to cover TCP_KEEPCNT and TCP_KEEPINTVL.

Revision history for this message

jbehling (john-behling) wrote on 2015-12-02:

osx_keystone_auth.patch Edit (1.3 KiB, text/x-diff)

Revision history for this message

Lance Bragstad (lbragstad) wrote on 2015-12-04:

Hi John,

I pulled down the patch to apply it locally and hit git errors with the current format (fatal: corrupt patch at line 27). Was the entire fix included in the patch?

[0] http://cdn.pasteraw.com/edaktq1btmsydot835lwilmx2ffenbi

Revision history for this message

jbehling (john-behling) wrote on 2015-12-07:

0001-make-TCP-defaults-conditional-on-the-SOCKET-object-s.patch Edit (1.9 KiB, text/plain)

Hi Lance, I made a mistake while creating the patch. I've attached the correct one now and verified that it works locally. Sorry for the sloppiness!

Revision history for this message

Morgan Fainberg (mdrnstm) wrote on 2015-12-21:

the general stance of OpenStack is "If it is not tested, it is broken" and we do not test OS X under any circumstances. This means that there is a very very strong chance that OS X support will break again in keystoneauth.

I am not opposed to landing a fix but it is important to know that this is not something that I am willing to commit any real energy to unless someone is spinning up 3rd party CI and working with the Infra team to validate / test support.

On a secondary note, posting patches to Launchpad and not to gerrit has the potential to violate the ICLA and/or corporal lawyer concerns of your organization. Please do not post non-embargoed patches to LP unless you follow up with contributing the patch yourself to gerrit. This patch is low risk, but opens the doors for other concerns. I don't want to see anyone on the wrong side of legal concerns by circumventing the workflow that is known for the openstack project.