Adapter mounting interface missing from Session

Bug #1516382 reported by Monty Taylor
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
keystoneauth
Fix Released
Medium
Monty Taylor

Bug Description

keystoneauth1.session.Session behaves like a requests.Session. However, attempting to pass it to betamax for replay REST testing shows that it's not fully complete in the Session interface. Most notably, it's missing the ability to manipulate adapters and mount them.

Monty Taylor (mordred)
Changed in keystoneauth:
assignee: nobody → Monty Taylor (mordred)
Changed in keystoneauth:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystoneauth (master)

Reviewed: https://review.openstack.org/245530
Committed: https://git.openstack.org/cgit/openstack/keystoneauth/commit/?id=3a7a703aff6b13808d871f1305303fa2936c9b96
Submitter: Jenkins
Branch: master

commit 3a7a703aff6b13808d871f1305303fa2936c9b96
Author: Monty Taylor <email address hidden>
Date: Sun Nov 15 07:59:35 2015 -0500

    Add three pieces of the Session interface

    In trying to use betamax with a keystoneauth1 Session, which interacts
    by mounting itself as an adapter, it became clear that our wrapping of
    requests.Session was incomplete in that regard. Adding an adapters
    property with a setter and a mount method worked and betamax is now
    totally usable with keystoneauth1.session.

    Closes-Bug:#1516382
    Change-Id: I1ebc4a726bb516349714e55eb97b384ed40b42cf

Changed in keystoneauth:
status: In Progress → Fix Committed
Changed in keystoneauth:
importance: Undecided → Medium
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/keystoneauth 2.0.0

This issue was fixed in openstack/keystoneauth 2.0.0 release.

Changed in keystoneauth:
milestone: none → 2.1.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.