Attempts to access domain_name or domain_id in https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/access.py raises TypeError exception.
To exercise this bug, add this test case (or similar access attempt to properties domain_id or domain_name) http://paste.openstack.org/show/401391/ to keystoneauth1/tests/unit/auth/test_access.py and run tox.
Some log details, when trying to reproduce the steps above:
======================================================================
FAIL: keystoneauth1.tests.unit.auth.test_access.AccessInfoPluginTests.test_domain_properties
tags: worker-3
----------------------------------------------------------------------
pythonlogging:'': {{{
Parsed 2015-07-22T21:56:30.876930 into {'separator': 'T', 'tz_minute': None, 'monthdash': '07', 'tz_sign': None, 'tz_hour': None, 'hour': '21', 'year': '2015', 'day': None, 'timezone': None, 'second': '30', 'daydash': '22', 'second_fraction': '876930', 'minute': '56', 'month': None} with default timezone <iso8601.iso8601.Utc object at 0x7f74e54a7090>
Got '2015' for 'year' with default None
Got '07' for 'monthdash' with default 1
Got 7 for 'month' with default 7
Got '22' for 'daydash' with default 1
Got 22 for 'day' with default 22
Got '21' for 'hour' with default None
Got '56' for 'minute' with default None
Got '30' for 'second' with default None
}}}
Traceback (most recent call last):======================================================================
FAIL: keystoneauth1.tests.unit.auth.test_access.AccessInfoPluginTests.test_domain_properties
tags: worker-3
----------------------------------------------------------------------
pythonlogging:'': {{{
Parsed 2015-07-22T21:56:30.876930 into {'separator': 'T', 'tz_minute': None, 'monthdash': '07', 'tz_sign': None, 'tz_hour': None, 'hour': '21', 'year': '2015', 'day': None, 'timezone': None, 'second': '30', 'daydash': '22', 'second_fraction': '876930', 'minute': '56', 'month': None} with default timezone <iso8601.iso8601.Utc object at 0x7f74e54a7090>
Got '2015' for 'year' with default None
Got '07' for 'monthdash' with default 1
Got 7 for 'month' with default 7
Got '22' for 'daydash' with default 1
Got 22 for 'day' with default 22
Got '21' for 'hour' with default None
Got '56' for 'minute' with default None
Got '30' for 'second' with default None
}}}
Traceback (most recent call last):
File "keystoneauth1/tests/unit/auth/test_access.py", line 65, in test_domain_properties
print auth_ref.domain_ids
File "keystoneauth1/access.py", line 49, in inner
return f(self)
File "keystoneauth1/access.py", line 612, in domain_id
return self._domain['id']
TypeError: 'NoneType' object has no attribute '__getitem__'
Ran 207 tests in 0.723s (+0.278s)
FAILED (id=2, failures=1)
error: testr failed (1)
We had a short discussion about this in IRC today. The issue is that since ``_domain`` is decorated as a ``missingproperty`` any KeyErrors will actually be returned as a None. There are other properties like ``domain_id`` and ``domain_name`` that don't check for a None before accessing the ``_domain`` as a dictionary.
I'm thinking these other properties should check for a None and raise a smarter error saying that a domain was not found.