keystoneclient session logging should have info about call stack

Bug #1421868 reported by Morgan Fainberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
Medium
Jamie Lennox

Bug Description

The Keystoneclient session should be able to provide a little more information at the debug level about the callstack specifically what the session was called from.

Right now we get something akin to:

2015-02-04 02:21:52.067 DEBUG keystoneclient.session [req-7666bf3a-7c16-4235-b1c4-b7e8e589c374 EC2VolumesTest-1100496527 EC2VolumesTest-1021092318] RESP: _http_log_response /usr/local/lib/python2.7/dist-packages/keystoneclient/session.py:199

In an ideal world, we should know what session was wrapped in (in this case it's cinderclient) or if it wasn't wrapped.

At a TRACE (see x-project spec) we probably want to emit the actual URI being requested and other information about the request itself. [future looking]

Changed in python-keystoneclient:
importance: Undecided → Medium
status: New → Triaged
assignee: nobody → Jamie Lennox (jamielennox)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/157647

Changed in python-keystoneclient:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/157647
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=c0a731204e3326d0446437f6c2849af9ad9c714b
Submitter: Jenkins
Branch: master

commit c0a731204e3326d0446437f6c2849af9ad9c714b
Author: Jamie Lennox <email address hidden>
Date: Fri Feb 20 14:00:54 2015 +1100

    Allow passing logger object to request

    It can become difficult to trace the client that created HTTP requests
    as the logging all goes through the keystoneclient.session logger. Allow
    passing the logger through the request function and make it able to be
    set via the adapter so it can be set once per client instantiation.

    Change-Id: Id45c315bee9a56f1c241210d667470751bf689d5
    Closes-Bug: #1421868

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Changed in python-keystoneclient:
milestone: none → 1.3.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.