oslo.serialization should be moved to test-requirements.txt on stable

Bug #1434152 reported by Matt Riedemann
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Invalid
Low
Matt Riedemann
Icehouse
Fix Released
Low
Matt Riedemann
Juno
Invalid
Low
Matt Riedemann

Bug Description

This added oslo.serialization to requirements.txt on stable/icehouse, probably to fix a gate blocker:

https://review.openstack.org/#/c/128850/

And that was cherry picked to stable/juno:

https://review.openstack.org/#/c/129170/

Those should be in test-requirements.txt since it's a testing requirement for master keystoneclient and stable keystone. The keystone code on stable/juno and stable/icehouse doesn't directly use oslo.serialization so it shouldn't be in requirements.txt.

Matt Riedemann (mriedem)
Changed in keystone:
assignee: nobody → Matt Riedemann (mriedem)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/165894

Revision history for this message
Matt Riedemann (mriedem) wrote :

Looks like the requirement is no longer needed given how the tests were changed to run in a venv:

https://review.openstack.org/#/q/I079fa77501b8987a4724d03a792b084a6d853e21,n,z

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/165928

Changed in keystone:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (stable/icehouse)

Reviewed: https://review.openstack.org/165928
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=e6eba4bf152c98dd1ff22125ec167ca59ba1ee4e
Submitter: Jenkins
Branch: stable/icehouse

commit e6eba4bf152c98dd1ff22125ec167ca59ba1ee4e
Author: Matt Riedemann <email address hidden>
Date: Fri Apr 10 08:47:52 2015 -0700

    Remove oslo.serialization from requirements.txt

    Change I00f66b0f3c8e9f688429ee78bd51608a4dcac140 added
    oslo.serialization to requirements.txt on stable to unwedge the gate due
    to keystone on stable testing against master level keystoneclient which
    required oslo.serialization.

    Later, change I079fa77501b8987a4724d03a792b084a6d853e21 fixed the
    testing problem by running the tests in a venv, so we can just
    remove oslo.serialization from keystone's requirements.txt now.

    Closes-Bug: #1434152

    Change-Id: I224a3652fba170da34da9935e6f8b4a161a856d2

tags: added: in-stable-icehouse
Alan Pevec (apevec)
Changed in keystone:
status: In Progress → Invalid
tags: removed: in-stable-icehouse
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (stable/juno)

Change abandoned by Matt Riedemann (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/165894
Reason: meh

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.