'Authors' check in run_tests.sh makes life harder for new contributers
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Glance |
Fix Released
|
Wishlist
|
Bhuvan Arumugam | ||
OpenStack Compute (nova) |
Fix Released
|
Wishlist
|
Monty Taylor | ||
OpenStack Core Infrastructure |
Fix Released
|
High
|
Bhuvan Arumugam | ||
OpenStack Dashboard (Horizon) |
Fix Released
|
Wishlist
|
Unassigned | ||
OpenStack Identity (keystone) |
Fix Released
|
Undecided
|
Unassigned | ||
OpenStack Object Storage (swift) |
Fix Released
|
Wishlist
|
Unassigned |
Bug Description
SInce gerrit commits are now gated on nova tests passing, the unit test that checks for an up to date Authors file should really be dropped.
Consider the scenario I am currently in
- I've never committed to nova before so I am not in Authors
- I have 2 independent changes I want to submit to nova
My options are:
- Submit both changes independently, both updating Authors to appease the tests. If both are accepted, one gets in first and the other has a conflict, requiring me to resend.
- Submit one change as the parent of another. This is confusing to reviewers since the changes are orthogonal, and one change is blocked on the other being accepted/committed.
- Submit one change, sit on the other until the first is resolved, then submit the second fix.
That's all stop energy for not a lot of benefit that I can see. The preferred way would be:
- Submit both changes independently and not worry about updating Authors.
If yall wanted to get fancy there is probably some git hook that can be used to auto update Authors. Simpler would be to just have the release manager regenerate Authors as part of cutting a release.
Changed in openstack-ci: | |
status: | New → In Progress |
assignee: | nobody → Bhuvaneswaran A (bhuvan) |
milestone: | none → folsom |
Changed in openstack-ci: | |
importance: | Undecided → High |
Changed in horizon: | |
importance: | Undecided → Wishlist |
status: | New → Confirmed |
Changed in keystone: | |
milestone: | none → folsom-1 |
Changed in glance: | |
importance: | Undecided → Wishlist |
Changed in keystone: | |
status: | Fix Committed → Fix Released |
Changed in glance: | |
milestone: | none → folsom-1 |
status: | Fix Committed → Fix Released |
Changed in glance: | |
assignee: | nobody → Bhuvaneswaran A (bhuvan) |
Changed in openstack-ci: | |
status: | In Progress → Fix Committed |
Changed in nova: | |
assignee: | nobody → Bhuvaneswaran A (bhuvan) |
importance: | Undecided → Wishlist |
Changed in swift: | |
importance: | Undecided → Wishlist |
status: | New → Confirmed |
Changed in nova: | |
milestone: | none → folsom-3 |
Changed in horizon: | |
status: | Confirmed → Fix Released |
Changed in openstack-ci: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in glance: | |
milestone: | folsom-1 → 2012.2 |
Changed in keystone: | |
milestone: | folsom-1 → 2012.2 |
Changed in nova: | |
milestone: | folsom-3 → 2012.2 |
I think Authors needs to be in sync with tree contents at any time, and not just for cosmetic reasons. Submitting one change as the parent of the other doesn't sound like too much of a hassle, to keep that benefit.
A git hook could replace it, but without .mailmap it can quickly turn the Authors file into something ugly.. and I'm not sure our Gerrit system would support that.
Adding openstack-ci for more comments.