keystone-manage db_sync --check misbehaves, version 15.1.0

[Jonathan Rosser]

We are seeing a difference in behaviour in keystone-manage between version 15.0.0 and 15.1.0.

The newer version always has a return code of zero, which means that in openstack-ansible we never initialise the keystone db - that process is driven by parsing the return code.

Here is an example of the return code being different between the different versions http://paste.openstack.org/show/776806/

[Colleen Murphy (krinkle)]

Confirmed that this is related to https://review.opendev.org/678322

http://paste.openstack.org/show/776811/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/682447
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=6bb14c0ff6c95bbce26ce8023ef621e408c111e6
Submitter: Zuul
Branch: master

commit 6bb14c0ff6c95bbce26ce8023ef621e408c111e6
Author: morgan fainberg <email address hidden>
Date: Mon Sep 16 11:15:25 2019 -0700

    Use correct repo for initial version check

    Use the actual repo for the initial version check of the db version when
    performing `db_sync --check`. Previously we always used the Legacy Repo
    as the repo path was not populated in the `get_init_version` function.

    This allowed the case where the new expand/contract/migrate repos
    matched the legacy repo version number, the `db_sync --check` command
    would assume that everything was properly up to date regardless of the
    version for the expand/contract/migrate repositories. This was most
    noticable in the case of a db not under version control.

    Change-Id: Id5e6f74a5ed96fdf17e2c241466897974aa5a218
    closes-bug: #1844157

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/keystone 16.0.0.0rc1 release candidate.