keystone-manage db_sync --check misbehaves, version 15.1.0

Bug #1844157 reported by Jonathan Rosser
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Morgan Fainberg

Bug Description

We are seeing a difference in behaviour in keystone-manage between version 15.0.0 and 15.1.0.

The newer version always has a return code of zero, which means that in openstack-ansible we never initialise the keystone db - that process is driven by parsing the return code.

Here is an example of the return code being different between the different versions

Colleen Murphy (krinkle)
Changed in keystone:
milestone: none → train-rc1
importance: Undecided → Critical
Revision history for this message
Colleen Murphy (krinkle) wrote :
Changed in keystone:
status: New → Confirmed
Changed in keystone:
assignee: nobody → Morgan Fainberg (mdrnstm)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Submitter: Zuul
Branch: master

commit 6bb14c0ff6c95bbce26ce8023ef621e408c111e6
Author: morgan fainberg <email address hidden>
Date: Mon Sep 16 11:15:25 2019 -0700

    Use correct repo for initial version check

    Use the actual repo for the initial version check of the db version when
    performing `db_sync --check`. Previously we always used the Legacy Repo
    as the repo path was not populated in the `get_init_version` function.

    This allowed the case where the new expand/contract/migrate repos
    matched the legacy repo version number, the `db_sync --check` command
    would assume that everything was properly up to date regardless of the
    version for the expand/contract/migrate repositories. This was most
    noticable in the case of a db not under version control.

    Change-Id: Id5e6f74a5ed96fdf17e2c241466897974aa5a218
    closes-bug: #1844157

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone

This issue was fixed in the openstack/keystone release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers