keystone upgrade fails q->r oslo.log requirement to low

Bug #1793347 reported by Tobias Urdin on 2018-09-19
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Medium
Unassigned
Ubuntu Cloud Archive
High
Unassigned
Rocky
High
Unassigned
keystone (Ubuntu)
High
Unassigned
Cosmic
High
Unassigned

Bug Description

When upgrading from Keystone queens to rocky the requirements.txt for rocky says oslo.log >= 3.36.0 but versionutils.deprecated.ROCKY is not introduced until 3.37.0

Should bump requirements.txt to atleast 3.37.0

Error when running db sync:
Traceback (most recent call last):
  File "/bin/keystone-manage", line 6, in <module>
    from keystone.cmd.manage import main
  File "/usr/lib/python2.7/site-packages/keystone/cmd/manage.py", line 19, in <module>
    from keystone.cmd import cli
  File "/usr/lib/python2.7/site-packages/keystone/cmd/cli.py", line 29, in <module>
    from keystone.cmd import bootstrap
  File "/usr/lib/python2.7/site-packages/keystone/cmd/bootstrap.py", line 17, in <module>
    from keystone.common import driver_hints
  File "/usr/lib/python2.7/site-packages/keystone/common/driver_hints.py", line 18, in <module>
    from keystone import exception
  File "/usr/lib/python2.7/site-packages/keystone/exception.py", line 20, in <module>
    import keystone.conf
  File "/usr/lib/python2.7/site-packages/keystone/conf/__init__.py", line 27, in <module>
    from keystone.conf import default
  File "/usr/lib/python2.7/site-packages/keystone/conf/default.py", line 60, in <module>
    deprecated_since=versionutils.deprecated.ROCKY,
AttributeError: type object 'deprecated' has no attribute 'ROCKY'

Corey Bryant (corey.bryant) wrote :

Thanks very much for reporting this Tobias. I will have a fix coming for the Ubuntu package. We use apt dist-upgrade in our upgrade tests which won't uncover this.

Changed in keystone (Ubuntu Cosmic):
status: New → Triaged
importance: Undecided → High
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package keystone - 2:14.0.0-0ubuntu2

---------------
keystone (2:14.0.0-0ubuntu2) cosmic; urgency=medium

  * d/control: Set min python-oslo.log to rocky version (3.39.0) as
    requirements.txt min version is too low (LP: #1793347).

 -- Corey Bryant <email address hidden> Thu, 20 Sep 2018 11:15:39 +0200

Changed in keystone (Ubuntu Cosmic):
status: Triaged → Fix Released
Changed in cloud-archive:
status: Triaged → Fix Committed
Corey Bryant (corey.bryant) wrote :

This bug was fixed in the package keystone - 2:14.0.0-0ubuntu2~cloud0
---------------

 keystone (2:14.0.0-0ubuntu2~cloud0) bionic-rocky; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 keystone (2:14.0.0-0ubuntu2) cosmic; urgency=medium
 .
   * d/control: Set min python-oslo.log to rocky version (3.39.0) as
     requirements.txt min version is too low (LP: #1793347).

Changed in cloud-archive:
status: Fix Committed → Fix Released
sunguangning (sunguangning) wrote :

There are the same question in centos7.4 when use kolla-ansible to deploy openstack rocky

TASK [keystone: Initialise fernet key authentication]**********************
FAILED -(10 retries left)

Traceback (most recent call last):
  File "/bin/keystone-manage", line 6, in <module>
    from keystone.cmd.manage import main
  File "/usr/lib/python2.7/site-packages/keystone/cmd/manage.py", line 19, in <module>
    from keystone.cmd import cli
  File "/usr/lib/python2.7/site-packages/keystone/cmd/cli.py", line 29, in <module>
    from keystone.cmd import bootstrap
  File "/usr/lib/python2.7/site-packages/keystone/cmd/bootstrap.py", line 17, in <module>
    from keystone.common import driver_hints
  File "/usr/lib/python2.7/site-packages/keystone/common/driver_hints.py", line 18, in <module>
    from keystone import exception
  File "/usr/lib/python2.7/site-packages/keystone/exception.py", line 20, in <module>
    import keystone.conf
  File "/usr/lib/python2.7/site-packages/keystone/conf/__init__.py", line 27, in <module>
    from keystone.conf import default
  File "/usr/lib/python2.7/site-packages/keystone/conf/default.py", line 60, in <module>
    deprecated_since=versionutils.deprecated.ROCKY,
AttributeError: type object 'deprecated' has no attribute 'ROCKY'

Corey Bryant (corey.bryant) wrote :

Hi sunguangning,

I'm not sure that you'll get attention for centos7.4 and kolla-ansible here. I'd recommend opening a bug against centos for this (I'm not sure where to do that) or checking in with the kolla-ansible folks, perhaps they have a channel on freenode.

Thanks,
Corey

Morgan Fainberg (mdrnstm) wrote :

This isn't something Keystone directly has control over, what is in our requirements/g-r is what we ship with. Marking as invalid for keystone server.

Changed in keystone:
status: New → Invalid
Colleen Murphy (krinkle) wrote :

Morgan, that's not true, we've switched to managing our own requirements:

http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html

Looking at stable/rocky we still refer to 3.36.0 so we do need to fix that ourselves http://git.openstack.org/cgit/openstack/keystone/tree/requirements.txt?h=stable/rocky#n31

Changed in keystone:
status: Invalid → Triaged
importance: Undecided → Medium
Adam Harwell (adam-harwell) wrote :

This just hit me today too, fortunately this came up quickly on Google. :)
I definitely do think it's up to Keystone to fix this in their rocky requirements...

Adam Harwell (adam-harwell) wrote :

Actually, I'd also like to point out that ROCKY isn't present until 3.38.0, which I think the packagers above figured out and used 3.39.0 instead.

Change abandoned by Colleen Murphy (<email address hidden>) on branch: stable/rocky
Review: https://review.openstack.org/643021
Reason: I just noticed we already have https://review.openstack.org/599447 - we should fix up that one instead.

Reviewed: https://review.openstack.org/599447
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=64c6c481ef45df1633535fbf9ece404a4f5d0dd1
Submitter: Zuul
Branch: stable/rocky

commit 64c6c481ef45df1633535fbf9ece404a4f5d0dd1
Author: Matthew Thode <email address hidden>
Date: Mon Sep 3 13:49:37 2018 -0500

    Update the minimimum required version of oslo.log

    keystone/conf/default.py is calling versionutils.deprecated.ROCKY
    which was added in 3.38.0

    Closes-bug: #1793347

    Change-Id: I26a8febbee4bb485d7b5ac444520161475d0646f
    (cherry picked from commit e41065849cd89712dfbad24a68d9fec082072959)
    Signed-off-by: Matthew Thode <email address hidden>

tags: added: in-stable-rocky

This issue was fixed in the openstack/keystone 14.1.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers