flaskification
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Identity (keystone) |
Fix Released
|
Medium
|
Morgan Fainberg |
Bug Description
Moving keystone to Flask away from it's home-grown WSGI framework is a long-term plan. The major reasons for this is to ensure we have an easy way for folks start contributing.
This will include a number of improvements including:
* moving to flask-restful for API definitions
* all routable paths will be owned by the base prefix (e.g. keystone.api.user will own everything under /user/)
* Paste Deploy removed
Changed in keystone: | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Morgan Fainberg (mdrnstm) |
milestone: | none → ongoing |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #1 |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #2 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit f18d54fe16dcc91
Author: Morgan Fainberg <email address hidden>
Date: Tue Jun 12 06:59:38 2018 -0700
Store JSON Home Resources off the composing router
JSON Home Resources must be stored in a location other
than the router for Flask as we are not composing routers
in the same way as we used to with the home-grown webob
based WSGI setup.
Partial-Bug: #1776504
Closes-Bug: #1776506
Change-Id: I292ea9e923ff2f
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #3 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #4 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master) | #5 |
Change abandoned by Morgan Fainberg (<email address hidden>) on branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #6 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #7 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #8 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #9 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 8dd2235cbc08f11
Author: Morgan Fainberg <email address hidden>
Date: Mon Jun 11 09:49:05 2018 -0700
Add Flask-RESTful and update flask minimum(s)
Keystone's move to flask requires more than the general Flask library
as Keystone is a RESTful (ish) API. We will be using Flask-RESTful for
the easier mechanism to implment a REST API than standard flask
blueprints.
This also increases the base flask minimum requirements to unblock
requirements updates (flask has been updated in g-r to minimum of
1.0.2)
Partial-Bug: #1776504
Change-Id: I398acad439f4e5
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #10 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit ecf721a3c176daf
Author: Morgan Fainberg <email address hidden>
Date: Mon Jun 11 17:25:45 2018 -0700
Keystone adheres to public_endpoint opt only
With the complete removal of the v2.0 API, keystone no longer
differentiates between admin and public endpoints. This change
deprecates the "admin_endpoint" configuration option and converts
keystone over to only using the public endpoint. The "admin" endpoint
was only used for unit testing purposes.
This change does not clean up all code related, it is aimed to make
the most minimal set of changes eliminating the use of the
"admin_
Partial-Bug: #1776504
Change-Id: I08f6f8ae078d65
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #11 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #12 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #13 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #14 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #15 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #16 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 3e3ba18bfaf8271
Author: Morgan Fainberg <email address hidden>
Date: Tue Jun 12 06:42:21 2018 -0700
Convert json_home and version discovery to Flask
Move the JSON Home Document and Version Discovery Documents out of
the webob-based mapper and into Flask.
This change removes the keystone.
keystone.
keystone.
The keystone.
are no "resources" and it must handle multiple types of responses
based upon the ACCEPTS header (JSON Home or JSON). In lieu of the
flask-RESTful mechanisms, keystone.
flask blueprint and functions. Minor scaffolding work has been done
to ensure the discovery blueprint can be loaded via the loader loop
in keystone.
keystone.
Partial-Bug: #1776504
Change-Id: Ib25380cefdbb71
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #17 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 3330c228ad030e6
Author: Morgan Fainberg <email address hidden>
Date: Tue Jun 19 12:55:24 2018 -0700
Add support for before and after request functions
In flask it is possible to register functions that will run before
and after every request, these are useful for ensuring certain
things occur (setting up environments) and protecting against
cases such as un-enforced API calls not explicitly white-listed.
Partial-Bug: #1776504
Change-Id: I0138a4676c1e25
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #18 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 1e870abd693088d
Author: Morgan Fainberg <email address hidden>
Date: Fri Jun 22 17:27:36 2018 -0700
Don't replace the whole app just the wsgi_app backing
Do not replace the entire app when wrapping with middleware. It is
important to maintain all the flask-functionality on the app object
and ensure any/all test client calls go through the entire stack of
app and middleware.
Partial-Bug: #1776504
Change-Id: I928d08e96b4c79
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #19 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 1bcc8a11c8f3fba
Author: Morgan Fainberg <email address hidden>
Date: Sat Jun 23 14:33:24 2018 -0700
Make it easy to identify a 404 from Flask
This change makes (for test purposes) the Flask app return a 418
instead of a 404 if the path is unrouted. This allows easy
identification (programmatically) if the 404 is issued from Flask
or is a handled 404 such as "UserNotFound"
Parital-Bug: #1776504
Change-Id: I0475d9b6315250
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #20 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit b77b5845d58b64b
Author: Morgan Fainberg <email address hidden>
Date: Tue Jun 26 14:46:01 2018 -0700
Address minor comments to 404 error detection
Addressing minor comments to the 404 detection mechanism.
Change-Id: Id8e2b5d5f81149
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #21 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #22 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #23 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit bb3b15bbf029935
Author: Morgan Fainberg <email address hidden>
Date: Sat Jun 23 14:33:50 2018 -0700
Implement base for new RBAC Enforcer
Create the base implementation of the RBAC enforcer with compat code
for the legacy mechanism via @protected decorators.
Change-Id: I80662d9b23e706
Parital-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #24 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit fb0299f661f590b
Author: Morgan Fainberg <email address hidden>
Date: Tue Jun 26 10:26:20 2018 -0700
Add support for enforce_call to set value on flask.g
When enforce_call is called, flask.g has the appropriate value set
in the known attribute location so that it can be determined if
enforce_call was used within a REST API request.
Change-Id: I08ecd2be0a8024
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #25 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 1caba2a44858ab4
Author: Morgan Fainberg <email address hidden>
Date: Sun Jul 1 10:26:15 2018 -0700
Move keystone.
The common functions are mostly removed and these make sense to
be part of the __init__.py. This also simplifies imports and
eliminates odd import errors due to duplicated names and masking
the names e.g. (and keystone.
from keystone.
keystone.
keystone.
Change-Id: Ie586fd45e10c8a
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #26 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 6d1456061defc01
Author: Morgan Fainberg <email address hidden>
Date: Sat Jun 30 08:17:33 2018 -0700
Address minor comments from initial impl RBACEnforcer
RBACEnforcer had a couple minor comments and this addresses all
except for adding explicit system-scope enforcement tests.
* Invalid "action" (policy rule name) now correctly raises
Forbidden instead of Unauthorized (it can never be authorized
as the code is incorrect, and a 500 "ISE" should never be expected).
This is equivalent behavior to an unknown rule in the oslo.policy
enforcer.
* Added more expressive errors/
* Code comments added where missing
Change-Id: I4895242555d2e9
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #27 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #28 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #29 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #30 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 16be22b428fd0c7
Author: Morgan Fainberg <email address hidden>
Date: Tue Jun 26 13:02:01 2018 -0700
Flesh out and add testing for flask_RESTful scaffolding
Add in support for JSON Home documents, a ResourceBase implementing
basic functionality, and full testing of the new flask_RESTful
scaffolding.
Change-Id: I5bcc8660b68c0b
Parital-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #31 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 9387dfd4cc39fa6
Author: Morgan Fainberg <email address hidden>
Date: Tue Jul 3 10:10:53 2018 -0700
Make keystone.
Importing keystone.
from the sub modules to develop APIs without needing to understand
all the underlying modules. __all__ has also be setup in a meaningful
way to allow for `from keystone.
all the needed objects to start developing APIs for keystone.
Change-Id: Iab22cabb71c669
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #32 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 0f4fd2e4f38d4e5
Author: Morgan Fainberg <email address hidden>
Date: Tue Jul 3 10:12:40 2018 -0700
Fix keystone.
keystone.
for the RBACEnforcer object. This limits the underlying module
knowledge needed to effectively work with the new flask RBACEnforcer.
Change-Id: I48cafa779ca189
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #33 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit dbc2ac06b8236c4
Author: Morgan Fainberg <email address hidden>
Date: Tue Jul 3 13:54:40 2018 -0700
Do not use flask.g imported as g
Always explicitly use flask.g as `flask.g` and do not do `from flask
import g`.
Change-Id: I3737115717d8a5
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #34 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #35 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #36 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #37 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #38 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #39 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #40 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 0d6b427fcc7f6b9
Author: Morgan Fainberg <email address hidden>
Date: Thu Jul 12 16:41:10 2018 -0700
Don't allow legacy and native flask to share paths
When a path-prefix is moved to flask native dispatching, no longer
allow that path prefix to be registered with the legacy dispatch
middleware. This will ensure the entire Keystone path is moved
and prevent bad behavior due to both dispatchers needing ot handle
a URL.
Change-Id: Ice800abf80a725
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #41 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #42 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #43 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit dbc6899c38f9721
Author: Morgan Fainberg <email address hidden>
Date: Fri Jul 13 20:32:29 2018 -0400
Properly remove content-type on HTTP 204
With a HTTP 204, we have no content, therefore no content type.
Change-Id: I39d36876d2ec37
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #44 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit ba854a5acd3938e
Author: Morgan Fainberg <email address hidden>
Date: Fri Jul 13 20:34:19 2018 -0400
Add correct self-link
The self-link was missing the resource id, properly add the id to
the self-link now.
Change-Id: I82c59fc3a02e41
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #45 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit cb130ffae86dcec
Author: Morgan Fainberg <email address hidden>
Date: Thu Jul 12 19:07:00 2018 -0700
Move Credentials API to Flask Native
Move the Credentials API to Flask Native dispatching.
This change fixes some circular importing in the
conversion.
Change-Id: I5e2485ba471d09
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #46 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit c008cbcea05e616
Author: Morgan Fainberg <email address hidden>
Date: Fri Jul 13 20:48:35 2018 -0400
Allow class-level definition of API URL Prefix
Add the ability to define API URL Prefix at the class-level. This
will be used only if no ap_url_prefix is passed into __init__.
Flask-restful handles prefixes in the order of `BAE` as used in Keystone:
* Blueprint
* API
* Endpoint (flask-endpoint)
This allows for additional prefixes such as "OS-TRUST" for
legacy/
non-"OS" prefixed pathes.
Change-Id: I7acf2f16a25efc
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #47 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #48 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #49 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #50 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #51 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 5ea59f52208e124
Author: Morgan Fainberg <email address hidden>
Date: Tue Jul 17 13:30:55 2018 -0700
Correctly pull input data for enforcement
Pull the actual input data into the enforcement target dict instead
of the view_args (the view args are something like 'trust_id', the
input data would be user-supplied json).
Change-Id: I9d7b1117d4decf
Partial-Bug: #1776504
Changed in keystone: | |
assignee: | Morgan Fainberg (mdrnstm) → wangxiyuan (wangxiyuan) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #52 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit f60c661d2ceab79
Author: Morgan Fainberg <email address hidden>
Date: Fri Jul 20 17:25:24 2018 +0000
Fix RBACEnforcer Comment
Fix the comment that is now inaccurate.
Change-Id: I38eeffa028f338
Partial-Bug: #1776504
Changed in keystone: | |
assignee: | wangxiyuan (wangxiyuan) → Morgan Fainberg (mdrnstm) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #53 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit ed5e88c5b6d3b4a
Author: Morgan Fainberg <email address hidden>
Date: Tue Jul 17 13:58:37 2018 -0700
Use oslo_serializat
Keystone's objects have a number of data types that do not serialize
cleanly with the defualt stdlib json library. This change makes
Keystone utilize oslo_serializat
restful.
Change-Id: I6c070b5e7bb231
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #54 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 1e7f3a1ad1e9d67
Author: Morgan Fainberg <email address hidden>
Date: Tue Jul 17 13:33:07 2018 -0700
Add pycadf initiator for flask resource
Add a pycadf initiator property for the flask resource
base. This allows for generation of a proper initiator
where needed in Keystone APIs.
Change-Id: Iaa3dd134cc2feb
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #55 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #56 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit d35a5edcab21db4
Author: Morgan Fainberg <email address hidden>
Date: Tue Jul 17 13:33:07 2018 -0700
Allow for 'extension' rel in json home
Allow providing an alternative REL function (e.g. for extensions)
in JSON Home in flask. The alternative functions are expected to
be functools.partial.
The extension-mode should only ever be used in the case of a keystone
API that was an extension (legacy style) and has not been converted
over to a new URI path; typically extensions start with an OS- prefix
in the URL.
All new APIs should not be using the 'extension' style.
Change-Id: I3970aef12f3b7c
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #57 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 68aa33a0c1faf30
Author: Morgan Fainberg <email address hidden>
Date: Tue Jul 17 13:37:36 2018 -0700
Trusts do not implement patch.
We do not actually implement patch. This is not part of our API and
this isn't testing anything specifically relevant. In Flask this
is 405. This is not an API contract break, as being unimplemneted
it is the responsibility of the underlying server to handle the
request.
Change-Id: I42975afa71ea08
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #58 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #59 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #60 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 3e948cfab4398c9
Author: Morgan Fainberg <email address hidden>
Date: Tue Jul 17 13:38:21 2018 -0700
Move trusts to flask native dispatching
Migrate trust APIs from legacy routes/webob to flask native
dispatching.
Change-Id: I6cba774c7dcf2f
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #61 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 6e74c6eab303cda
Author: Morgan Fainberg <email address hidden>
Date: Thu Jul 19 20:25:06 2018 -0700
Implement "no-update" test for trusts
Trusts explicitly do not implement "patch" or "put". We now explicitly
test for a 405 (Method Not Allowed), as updates are outside of the
Keystone API, in an isolated test.
Change-Id: I9b84732506f85d
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #62 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 1c5affbddb0f3f6
Author: Morgan Fainberg <email address hidden>
Date: Fri Jul 20 11:22:21 2018 -0700
Boostrap CLI tests no longer call auth controller
Ensure the CLI tests no longer directly call the auth controller.
If it is desireable to call a controller method, make sure it is
done through the complete WSGI stack. This ensures no test changes
are needed when moving `/auth` to flask (test changes are isolated)
Change-Id: Id4f795d2e47911
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #63 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #64 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #65 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit f5c9b094af84422
Author: Morgan Fainberg <email address hidden>
Date: Fri Jul 20 11:37:01 2018 -0700
Move validate_
For the move to flask, and to ensure there are no test changes,
this changeset moves `validate_
the auth.schema module (as it is clearly about validation).
Change-Id: I97e07cbebb4e97
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #66 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #67 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 6dbd0058421feb9
Author: Morgan Fainberg <email address hidden>
Date: Fri Jul 20 14:51:01 2018 -0700
Remove direct calls to auth.controllers in some tests
Tests in keystone.
no longer directly instantiate or calls to the auth controllers. The
only exception are test classes that are not used, those have had a
TODO note added to them. This is being done for the conversion to flask
where the auth controllers will no longer exist. All test changes are
done outside of the conversion of webob controller -> flask restful
api.
Change-Id: Ib668ca18faf42b
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #68 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit da4eb43f5c74ffc
Author: Morgan Fainberg <email address hidden>
Date: Thu Jul 19 11:46:13 2018 -0700
Move unenforced_api decorator to module function
Move the unenforced_api decorator off the APIBase object and into
the module. It is likely the code would require calling the decorator
from the module level anyway since the Resource is added to a list
that is a property of the API. Moving the decorator makes it so the
call is more akin to @keystone_
@keystone_
Change-Id: Ic1d5466bc26c76
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #69 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit a4d9a4f13b21fbd
Author: Morgan Fainberg <email address hidden>
Date: Tue Jul 31 15:05:15 2018 -0700
Convert OS-REVOKE to flask dispatching
Convert OS-REVOKE to flask dispatching.
Change-Id: I2504d4326b8c35
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #70 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #71 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #72 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #73 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #74 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #75 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #76 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #77 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 6f07b4c1ff69c49
Author: Morgan Fainberg <email address hidden>
Date: Wed Aug 1 11:47:33 2018 -0700
Convert OS-AUTH1 paths to flask dispatching
Convert OS-AUTH1 paths to native flask dispatching.
Change-Id: Iad54005b4dbfaf
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #78 |
Fix proposed to branch: master
Review: https:/
Changed in keystone: | |
assignee: | Morgan Fainberg (mdrnstm) → Lance Bragstad (lbragstad) |
Changed in keystone: | |
assignee: | Lance Bragstad (lbragstad) → Morgan Fainberg (mdrnstm) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #79 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 3bad4cdbb78f88c
Author: Morgan Fainberg <email address hidden>
Date: Wed Aug 1 14:15:24 2018 -0700
Convert limits and registered limits to flask dispatching
Convert limits and registered limits to flask native dispatching.
NOTE: A minor test change was needed. The limit JSON Home data
was incorrectly formatted and did not properly isolate the
singular forms of "limit" and "registered_limit" from the
plural (list) APIs.
Change-Id: Ib3ceeb0a249ccc
Partial-Bug: #1776504
Changed in keystone: | |
assignee: | Morgan Fainberg (mdrnstm) → Lance Bragstad (lbragstad) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #80 |
Fix proposed to branch: master
Review: https:/
Changed in keystone: | |
assignee: | Lance Bragstad (lbragstad) → Morgan Fainberg (mdrnstm) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #81 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master) | #82 |
Change abandoned by Morgan Fainberg (<email address hidden>) on branch: master
Review: https:/
Reason: Duplicate.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #83 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #84 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #85 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #86 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #87 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #88 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #89 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #90 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #91 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 8eaf0854ff81b8c
Author: Morgan Fainberg <email address hidden>
Date: Mon Aug 6 10:45:39 2018 -0700
Migrate OS-EP-FILTER to flask native dispatching
Migrate the OS-EP-FILTER API to flask-native dispatching. This does
not migrate the standard catalog "region", "service" or "endpoint"
APIs.
Change-Id: Ia7c2ab211e2f7f
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #92 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 637990bf71a631a
Author: Morgan Fainberg <email address hidden>
Date: Mon Aug 6 13:40:13 2018 -0700
Convert OS-SIMPLE-CERT to flask dispatching
Convert OS-SIMPLE-CERT to flask native dispatching.
Change-Id: I7b58c50f1ef870
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #93 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 13897ef69b6ebec
Author: Morgan Fainberg <email address hidden>
Date: Tue Aug 7 09:41:13 2018 -0700
Pass path into full_url and base_url
This change mirrors what was done prior to flask and leans on the
base_url and full_url functions to append '/v3' and the path or
collection_
wrap_collection to properly handle local-only wrapping (no need
to cross-api call wrap because a "role" is returned from the "trust"
api).
Change-Id: I5376d8abc58199
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #94 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 72b59b0ccbf72b9
Author: Morgan Fainberg <email address hidden>
Date: Tue Aug 7 10:50:37 2018 -0700
Allow wrap_member and wrap_collection to specify target
Allowing targeting of the types for wrap_member and wrap_collection.
This prevents the need to cross-call controllers such as wrapping role
refs fro the trust api.
Change-Id: Id8658cf6fba2fb
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #95 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 84c074f28c60ca9
Author: Morgan Fainberg <email address hidden>
Date: Tue Aug 7 13:35:48 2018 -0700
Convert regions API to flask native dispatching
Convert regions API to flask native dispatching.
Change-Id: Ic38065441adb33
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #96 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 18c6e838b95992b
Author: Morgan Fainberg <email address hidden>
Date: Tue Aug 7 13:52:48 2018 -0700
Convert services api to flask native dispatching
Convert the services api to flask native dispatching.
Change-Id: Ibdecc157e1f540
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #97 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 56d9c30f8f64c79
Author: Morgan Fainberg <email address hidden>
Date: Tue Aug 7 14:13:43 2018 -0700
Convert endpoints api to flask native dispatching
Convert endpoints api to flask native dispatching.
Change-Id: I684e6117dc7fdd
Partial-Bug: #1776504
Changed in keystone: | |
assignee: | Morgan Fainberg (mdrnstm) → Lance Bragstad (lbragstad) |
Changed in keystone: | |
assignee: | Lance Bragstad (lbragstad) → Morgan Fainberg (mdrnstm) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #98 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit cfc5a730b75bff0
Author: Morgan Fainberg <email address hidden>
Date: Wed Aug 8 13:12:22 2018 -0700
Convert Roles API to flask native dispatching
Convert Roles and Implied Roles (all paths under /v3/roles) to
flask native dispatching. This change does not convert
/v3/
Change-Id: I114380e96c6a2b
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #99 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 0f5300ddb3a7ac4
Author: Morgan Fainberg <email address hidden>
Date: Thu Aug 9 12:59:10 2018 -0700
Convert role_inferences API to flask native dispatching
Convert /v3/role_inferences API to flask native dispatching.
Change-Id: I4a2719f27bb314
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #100 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 4ec63548c24eb70
Author: Morgan Fainberg <email address hidden>
Date: Thu Aug 9 17:33:50 2018 -0700
Add callback action back in
Add the callback action to delete endpoint group association by project
that was dropped in the conversion of OS-EP-FILTER to flask.
Change-Id: Id16f18f6bac9b2
Partial-Bug: #1776504
Changed in keystone: | |
assignee: | Morgan Fainberg (mdrnstm) → Lance Bragstad (lbragstad) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #101 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 665d5beda7e5291
Author: Morgan Fainberg <email address hidden>
Date: Thu Aug 9 14:24:00 2018 -0700
Convert role_assignments API to flask native dispatching
Convert the role_assignments API to flask native dispatching.
Change-Id: I77f64f025d8dbc
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #102 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 180f2ce5e640d10
Author: Morgan Fainberg <email address hidden>
Date: Thu Aug 9 17:28:54 2018 -0700
Convert system (role) api to flask native dispatching
Convert the /system API (used for granting roles to the system scope) to
Flask native dispatching.
Change-Id: I48b04f2d0e9d85
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #103 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 41f23eed512f362
Author: Morgan Fainberg <email address hidden>
Date: Fri Aug 10 10:49:30 2018 -0700
Move json_home "extension" rel functions
Move the json_home "extension" rel functiond to a common location
so that they may be shared as needed between apis. Since there
are no new extensions for keystone, once keystone is moved to being
100% flask dispatched, no new relation functions will need to be
added to keystone.
Change-Id: I7040526acccee6
Partial-Bug: #1776504
Changed in keystone: | |
assignee: | Lance Bragstad (lbragstad) → wangxiyuan (wangxiyuan) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #104 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 87a39635eb047ab
Author: Lance Bragstad <email address hidden>
Date: Wed Aug 8 15:52:46 2018 +0000
Convert policy API to flask
Migrate the policy APIs to use flask-native dispatching.
Change-Id: I03fc72b19e85df
Partial-Bug: #1776504
Changed in keystone: | |
assignee: | wangxiyuan (wangxiyuan) → Morgan Fainberg (mdrnstm) |
Changed in keystone: | |
assignee: | Morgan Fainberg (mdrnstm) → Adam Young (ayoung) |
Changed in keystone: | |
assignee: | Adam Young (ayoung) → nobody |
assignee: | nobody → Morgan Fainberg (mdrnstm) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #105 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #106 |
Fix proposed to branch: master
Review: https:/
Changed in keystone: | |
assignee: | Morgan Fainberg (mdrnstm) → Gage Hugo (gagehugo) |
Changed in keystone: | |
assignee: | Gage Hugo (gagehugo) → Morgan Fainberg (mdrnstm) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (stable/rocky) | #107 |
Fix proposed to branch: stable/rocky
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #108 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #109 |
Fix proposed to branch: master
Review: https:/
Changed in keystone: | |
assignee: | Morgan Fainberg (mdrnstm) → Gage Hugo (gagehugo) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master) | #110 |
Change abandoned by Morgan Fainberg (<email address hidden>) on branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #111 |
Change abandoned by Morgan Fainberg (<email address hidden>) on branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #112 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 94f8f103abc6911
Author: Morgan Fainberg <email address hidden>
Date: Fri Aug 10 13:41:52 2018 -0700
Convert OS-FEDERATION to flask native dispatching
Convert OS-FEDERATION to flask native dispatching.
NOTE: Two changes occured that impact testing in this patch.
* The JSON Home test now uses assertDictEquals to make it
easier to debug json_home document errors
* It was by general good luck that the overloaded relation
used for both '/OS-FEDERATION
the Identity-
to the JSON Home document and the tests make the
of 'identity_
with 'websso' relation for
this constitutes a minor break in our contract (the
output of the json home document) it was required to
ensure consistency and functionality. The alternative
is to not represent '/OS-FEDERATION
(list endpoint) in the JSON Home document at all, instead
Change-Id: If746c14491322d
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #113 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 8696865b13667fe
Author: morgan fainberg <email address hidden>
Date: Wed Sep 12 11:39:46 2018 -0700
Address issues with flask conversion of os-federation
This change addresses the following issues with the flask conversion:
* Filter attributes on get_idp (added to wrap_member)
Change-Id: I028f894845d1d6
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master) | #114 |
Change abandoned by Morgan Fainberg (<email address hidden>) on branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #115 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 22f5f7303f9e366
Author: Morgan Fainberg <email address hidden>
Date: Sat Aug 11 05:17:22 2018 -0700
Fix RBACEnforcer get_member_
Correct an issue with the RBACEnforcer requiring 'member_name' instead
of 'member_key' for the inferred lookup. Due to how flask works and that
all views are instantiated on demand (and not accessible outside of
the active method without a lot of extra introspection), the provider
object now supports a "deferred" lookup mechanism. This mechanism
leverages the descriptor construct and does the lookup of the provider
api property and method at runtime. This, in essence, works like a
"@classprop
Change-Id: I264384dd521ea6
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #116 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 2a04d78dbfe7f52
Author: Morgan Fainberg <email address hidden>
Date: Fri Aug 10 20:05:14 2018 -0700
Convert groups API to flask native dispatching
Convert the groups API to flask native dispatching.
Change-Id: I2c15d4eba13309
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #117 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 8c397fa727c8438
Author: Morgan Fainberg <email address hidden>
Date: Sat Aug 11 11:29:59 2018 -0700
Convert OS-INHERIT API to flask native dispatching
Convert OS-INHERIT API to flask native dispatching.
NOTE: A minor test change was needed, the test was mis-constructing the
URI with multiple slashes. The test now properly constructs the URI
using an lstrip when combining the direct_url bits.
Change-Id: I0907eb00cdfb98
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #118 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 4975b79e8174587
Author: morgan fainberg <email address hidden>
Date: Tue Sep 11 16:03:54 2018 -0700
Ensure view args is in policy dict
The policy_dict (in enforcement) was not populating the view args
in a similar manner to the old style @protected decorator. This
change ensures that we mirror the old behavior (required for
proper use of v3cloud policy).
Change-Id: Ida9009a95a874b
Partial-Bug: #1776504
Closes-Bug: #1792047
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #119 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 296f20f0a7e2678
Author: Gage Hugo <email address hidden>
Date: Tue Aug 28 20:35:50 2018 -0500
Convert domains api to flask
Convert domains api to flask native dispatching.
Change-Id: I974ab112986e6c
Partial-Bug: #1776504
Changed in keystone: | |
assignee: | Gage Hugo (gagehugo) → Felipe Monteiro (fm577c) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #120 |
Fix proposed to branch: master
Review: https:/
Changed in keystone: | |
assignee: | Felipe Monteiro (fm577c) → Harry Rybacki (hrybacki-h) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master) | #121 |
Change abandoned by Morgan Fainberg (<email address hidden>) on branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #122 |
Fix proposed to branch: master
Review: https:/
Changed in keystone: | |
assignee: | Harry Rybacki (hrybacki-h) → Morgan Fainberg (mdrnstm) |
Changed in keystone: | |
assignee: | Morgan Fainberg (mdrnstm) → Harry Rybacki (hrybacki-h) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #123 |
Fix proposed to branch: master
Review: https:/
Changed in keystone: | |
assignee: | Harry Rybacki (hrybacki-h) → wangxiyuan (wangxiyuan) |
Changed in keystone: | |
assignee: | wangxiyuan (wangxiyuan) → Harry Rybacki (hrybacki-h) |
Changed in keystone: | |
assignee: | Harry Rybacki (hrybacki-h) → Morgan Fainberg (mdrnstm) |
Changed in keystone: | |
assignee: | Morgan Fainberg (mdrnstm) → Gage Hugo (gagehugo) |
Changed in keystone: | |
assignee: | Gage Hugo (gagehugo) → Morgan Fainberg (mdrnstm) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #124 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 8697da7da650e2d
Author: Gage Hugo <email address hidden>
Date: Tue Sep 11 17:26:24 2018 -0600
Add build_target arguement to enforcer
This change adds in a new arguement "build_target" which takes
in a passed function to build the enforement target after
the authentication check. This is to avoid leaking existance
data when determining scope.
Change-Id: I9aab71dd0032d4
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #125 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit d027dd2ba913462
Author: wangxiyuan <email address hidden>
Date: Thu Sep 20 11:25:21 2018 +0800
Add hint back
When do Flask refactor, some list APIs missed "hints"
for wrap_collection.
Add them back for list resource so that filters can work as
before
Change-Id: If32ca8d798c954
Partial-Bug: #1776504
Changed in keystone: | |
assignee: | Morgan Fainberg (mdrnstm) → Harry Rybacki (hrybacki-h) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (stable/rocky) | #126 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: stable/rocky
commit 0c71cdd23bd2a7e
Author: morgan fainberg <email address hidden>
Date: Tue Sep 11 16:03:54 2018 -0700
Ensure view args is in policy dict
The policy_dict (in enforcement) was not populating the view args
in a similar manner to the old style @protected decorator. This
change ensures that we mirror the old behavior (required for
proper use of v3cloud policy).
Conflicts:
Change-Id: Ida9009a95a874b
Partial-Bug: #1776504
Closes-Bug: #1792047
(cherry picked from commit 4975b79e8174587
tags: | added: in-stable-rocky |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #127 |
Fix proposed to branch: master
Review: https:/
Changed in keystone: | |
assignee: | Harry Rybacki (hrybacki-h) → Morgan Fainberg (mdrnstm) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #128 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #129 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #130 |
Fix proposed to branch: master
Review: https:/
Changed in keystone: | |
assignee: | Morgan Fainberg (mdrnstm) → Harry Rybacki (hrybacki-h) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #131 |
Fix proposed to branch: master
Review: https:/
Changed in keystone: | |
assignee: | Harry Rybacki (hrybacki-h) → Morgan Fainberg (mdrnstm) |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #132 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #133 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit d97832e8e826e37
Author: morgan fainberg <email address hidden>
Date: Tue Sep 18 10:54:59 2018 -0700
Convert auth to flask native dispatching
Convert the /auth paths to flask native dispatching.
A minor change to additional_urls was implemented to ensure all
urls are added at once instead of individually (causing an over-
write issue within flask as a single resource may only have a
single set of URL mappings).
Alternate URLs now support adding alternate JSON Home rel links.
This is to support the case of OS-FEDERATION auth routes moving
to /auth. The old JSON Home entries must exist but reference
the new paths.
This port includes the following test changes (needed due to the
way flask handles requests and the way requests are passed through
the auth system):
* Implemented keystone.
containing render_
of keystone.
Minor differences occur in render_
the keystone.
for referencing data from flask instead of the request object.
* Test cases have been modified to no longer rely on the auth
controller(s) directly
* Test cases now use "make_request" as a context manager
since authenticate/
reference the flask contexts and must have an explicit
context pushed.
* Test cases no longer pass request objects into methods
such as authenticate/
methods on the auth plugins
* Test cases for federation reference the token model now
where possible instead of the rendered token response.
Rendered token responses are generated where needed.
* Auth Plugin Configuration is done in test core as well.
This is because Auth controller does not exist.
NOTE: This is a massive change, but must of these changes
were now easily uncoupled because of how far reaching auth
is.
Change-Id: I63692810287576
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #134 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 54b6227c1fdec1e
Author: Morgan Fainberg <email address hidden>
Date: Mon Oct 8 12:28:42 2018 -0700
Auth flask conversion cleanup
* Superfluous call to setup token authentication has been removed from
keystone.
* Base SAML assertion function has been extracted from
keystone.
Change-Id: Idfa62bf1aea81e
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master) | #135 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #136 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #137 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #138 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #139 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #140 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #141 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #142 |
Fix proposed to branch: master
Review: https:/
Changed in keystone: | |
milestone: | ongoing → stein-1 |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #143 |
Fix proposed to branch: master
Review: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master) | #144 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 86f968163ea90df
Author: Morgan Fainberg <email address hidden>
Date: Mon Oct 8 14:40:56 2018 -0700
Convert /v3/users to flask native dispatching
Convert /v3/users to use flask native dispatching.
The following test changes were required:
* Application Credentials did not have the plural form
in the JSON Home document. The JSON Home document was
corrected both in code and in tests.
* Application Credentials "patch" test needed to be
refactored to look for METHOD_NOT_ALLOWED instead
of NOT FOUND for invalid/
The "assertValidErr
insufficient and the test now uses the flask
test_client mechanism instead.
Change-Id: Iedaf405d11450b
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #145 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 46380baeb76fc62
Author: Harry Rybacki <email address hidden>
Date: Tue Sep 18 12:03:52 2018 -0400
Convert projects API to Flask
Convert the projects API to Flask native dispatching.
Change-Id: I3406284acfb795
Co-Authored-By: Morgan Fainberg <email address hidden>
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #146 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 0ab08e75b237dd2
Author: Morgan Fainberg <email address hidden>
Date: Tue Oct 9 14:36:20 2018 -0700
Remove skip for test_locked_
Remove the explicit skip added pre-user conversion to flask for
test_
Change-Id: I5f2e83f24dca27
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #147 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 35c9bb7eff51ebd
Author: Morgan Fainberg <email address hidden>
Date: Tue Oct 9 17:15:50 2018 -0700
Convert S3 and EC2 auth to flask native dispatching
Convert S3 and EC2 auth to flask native dispatching.
Test changes required:
* Eliminate direct reference of the EC2 / S3 controllers, originally
this direct reference was to verify signature checking. Since
signature checking is an @staticmethod now, direct reference of
the API resources covers everything.
* Direct import of keystone.
how our WSGI code work(s) in test, if nothing imports the common
controller module, the tests fail using the oslo import_class
mechanism.
Change-Id: I06e95957b3ea3a
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #148 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit ee9b035cf17f007
Author: Morgan Fainberg <email address hidden>
Date: Wed Oct 10 13:12:32 2018 -0700
Replace JSON Body middleware with flask-native func
Replace the JSON Body middleware with flask-native before-request
function.
The body filtering and storing data in
request.
has been dropped.
Test Changes:
* JSON Body middleware has been removed, no testing of the removed code
* JSON Body Before Request Method has been implemented and associated
testing (mirroring the JSON Body middleware code).
* Test entry points no longer looks for JSON Body middleware.
Change-Id: I84491865870b6b
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #149 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit e666839bc170ee3
Author: Morgan Fainberg <email address hidden>
Date: Wed Oct 10 14:23:12 2018 -0700
Cleanup keystone.
Remove a chunk of the compat code for legacy dispatching. This moves
the logging about the request to it's own before_request function.
Change-Id: I0b1a4ca9a95489
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #150 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 9b052e4c0598937
Author: Morgan Fainberg <email address hidden>
Date: Thu Oct 11 12:32:59 2018 -0700
Register exceptions with a Flask Error Handler
Exceptions are now handled in the Flask APP instead of in the
legacy webob Application code (at this point that code was living
in the URL Normalizing Middleware). All Keystone API exceptions
(derived from keystone.
registered on definition with the
keystone.
processed once the app is created in keystone.
to the flask-friendly handler.
TypeError and generic Exception are registered to an explicit
error handler that converts TypeError to ValidationError (BAD_REQUEST)
and all other Exceptions to UnexpectedError (INTERNAL SERVER ERROR).
These exceptions are then emitted in a "jsonify-ed" manner to the
client.
Two other minor changes were required:
* Unenforced API decorator had it's core functionality split into
a dedicated function that can be called in the case of an error
being raised in a "before_request" function (such as validation
in the JSON Body before request func.
* The JSON Body before request func now explicitly sets the
api to "unenforced_ok" if it is raising an exception. This
prevents the flask "was this API enforced" assertion from failing
because @unenforced_api was never run (the ValidationError was
raised prior to the resource's method being called).
Change-Id: I0d0ef6a774eb86
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #151 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 1c05f5f88d84d90
Author: Morgan Fainberg <email address hidden>
Date: Thu Oct 11 13:05:16 2018 -0700
Make Request Logging a little better
Use the flask.request properties instead of direct environ lookups,
as this is more representative of what is happening in the application.
Change-Id: Ic16c5ea26b2f52
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #152 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 18d597f8e87a7eb
Author: Morgan Fainberg <email address hidden>
Date: Thu Oct 11 13:20:36 2018 -0700
Internally defined middleware don't use stevedore
For internally defined middleware (URL Normalizer and AuthContext)
Do not use stevedore to load, apply directly. This also cleans up
a lingering entry in the setup.cfg for token_auth.
Test Changes:
* entry points test no longer looks for url_normalize and
build_
Change-Id: I58d3c23ad4f706
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #153 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 848c8fa6385f690
Author: Morgan Fainberg <email address hidden>
Date: Thu Oct 11 13:47:18 2018 -0700
Convert Normalizing filter to flask native Middleware
Normalizing filter has been converted to a flask-native style
middleware instead of leaning on the old application logic from
Webob. We also now strip all trailing slashes, not just a single
traling slash.
Test Changes:
* test_url_middleware now tests the new middleware directly instead
of leaning on webob and fake requests.
Change-Id: I5f82817b61a928
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #154 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 595967bba6c19b7
Author: Morgan Fainberg <email address hidden>
Date: Thu Oct 11 13:59:58 2018 -0700
Move AuthContextMidd
Move AuthContextMidd
to be more in line with the other internally defined middleware.
Change-Id: I25b6a88f4b0dc3
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #155 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 8a6f1759331cef6
Author: Morgan Fainberg <email address hidden>
Date: Thu Oct 11 14:06:57 2018 -0700
Flask comment/docstring cleanup
Address a few nits in docstrings and comments from the flask conversion
patches.
Change-Id: I058d50168c8e5f
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #156 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit ce93950f44b76b4
Author: Morgan Fainberg <email address hidden>
Date: Thu Oct 11 14:30:54 2018 -0700
Cleanup test_wsgi
Cleanup test_wsgi and remove un-needed tests. Rename to test_app_config
to more closely match what is, in-fact, tested now.
Change-Id: Ifb9dd311da8559
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #157 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 5c70aef2dacf801
Author: Morgan Fainberg <email address hidden>
Date: Fri Oct 12 10:30:04 2018 -0700
Make collection_key and member_key raise if unset
Instead of populating with __UNUSED__ or other silly string, make
direct use of "collection_key" or "member_key" raise a ValueError
if they are unset and referenced.
Change-Id: Idf4f4df9d93331
Partial-Bug: #1776504
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : | #158 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 184c84ae76b1e4d
Author: Morgan Fainberg <email address hidden>
Date: Thu Oct 11 15:16:02 2018 -0700
Remove pre-flask legacy code
This removes common.controller, common.extension, common.router, and
common.wsgi. Relevant code from common.wsgi (used by AuthContext) was
moved into keystone.
keystone.
test_middleware and test_exception were modified to reflect the changes
to the remaining code from keystone.
keystone.
work now.
Routes is removed from requirements.txt
Release-Note for migration to flask added.
Change-Id: I81563b6a49c8f1
Closes-Bug: #1776504
Changed in keystone: | |
status: | In Progress → Fix Released |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 15.0.0.0rc1 | #159 |
This issue was fixed in the openstack/keystone 15.0.0.0rc1 release candidate.
Fix proposed to branch: master /review. openstack. org/574953
Review: https:/