list_limit for domain doesn't work correct

Bug #1760521 reported by wangxiyuan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
wangxiyuan

Bug Description

This bug is found during adding FK for test: https://review.openstack.org/#/c/558029/

Reproduce:
1. suppose there are 4 domain in your openstack env.
2. set the config option list_limit in [resource] section to 3. Then restart Keystone.
   [resource] list_limit = 3
3. try to list domain.
   openstack domain list

Expect result: three domains should return.

Actual result only two domains returned.

reproduce step: http://paste.openstack.org/show/718138/

wangxiyuan (wangxiyuan)
Changed in keystone:
assignee: nobody → wangxiyuan (wangxiyuan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/558150

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/558151

Revision history for this message
Lance Bragstad (lbragstad) wrote :

I was able to recreate this locally [0].

[0] http://paste.openstack.org/show/718197/

Changed in keystone:
status: In Progress → Confirmed
importance: Undecided → Medium
Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/558150
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=c522fc3bb728eed1838aadc708bbd59763544cfe
Submitter: Zuul
Branch: master

commit c522fc3bb728eed1838aadc708bbd59763544cfe
Author: wangxiyuan <email address hidden>
Date: Mon Apr 2 10:42:47 2018 +0800

    Expose a bug that list_limit doesn't work correctly

    The list_limit for domain list doesn't work
    correctly. The return count will less than
    list_limit if the sql query contains root domain

    This patch expose this bug and it will be fixed
    in the following patch.

    Co-Authored-By: Lance Bragstad<email address hidden>

    Partial-bug: #1760521

    Change-Id: Ib28793c97f1b730cb3b83b046e653a7b660af875

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/558151
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=245a0c718b0a82419a2d34311d3a2b5c19021fa9
Submitter: Zuul
Branch: master

commit 245a0c718b0a82419a2d34311d3a2b5c19021fa9
Author: wangxiyuan <email address hidden>
Date: Mon Apr 2 10:00:50 2018 +0800

    Fix list_limit doesn't work correctly for domain

    This patch changed the sql query for domain list
    to ensure the return count is correct if list_limit
    is set for resource.

    Closes-bug: #1760521

    Change-Id: I690a9815fe2c35e6191ab3ac789e34736e0d637c

Changed in keystone:
milestone: none → rocky-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 14.0.0.0b1

This issue was fixed in the openstack/keystone 14.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.