Keystone raise 500 error when authorize request token with invalid body.
reproduce:
1. create a request token first, suppose the token key is f13b2c6755634131b59cf5fa08d49331
2. PUT http://keystone-server/v3/OS-OAUTH1/authorize/f13b2c6755634131b59cf5fa08d49331 with body:
{
"roles": [
{
"id": "711aa6371a6343a9a43e8a310fbe4a6f"
},
{
"name": "admin"
}
]
}
Keystone will raise 500 error. error log:
Traceback (most recent call last):
File "/opt/stack/keystone/keystone/common/wsgi.py", line 226, in __call__
result = method(req, **params)
File "/opt/stack/keystone/keystone/common/controller.py", line 82, in inner
return f(self, request, *args, **kwargs)
File "/opt/stack/keystone/keystone/oauth1/controllers.py", line 404, in authorize_request_token
authed_roles.add(role['id'])
KeyError: 'id'
here are two things we can improve:
1. Add the schema check for request token authorize API
2. Support role name.
To fix the 500 error, step 1 is enough.
Fix proposed to branch: master
Review: https:/