Error number should be used when throwing IOError exception

[Daniel Park]

In some parts of the code, Keystone is raising an IOError with just a string. While this does work, it would be helpful to include an error number using the errno library.

https://github.com/openstack/keystone/blob/68f1043ce2a96e3d9a1e458c825800c061c95fe2/keystone/identity/backends/ldap/common.py#L595
https://github.com/openstack/keystone/blob/68f1043ce2a96e3d9a1e458c825800c061c95fe2/keystone/identity/backends/ldap/common.py#L607
https://github.com/openstack/keystone/blob/0d845e0316955eca5ed85b610d587d6667ea2bac/keystone/federation/idp.py#L496

This would also prevent a UnicodeError exception from being thrown in an environment that is using an older version of oslo.i18n (< 3.1.0).

[Lance Bragstad (lbragstad)]

Are any of these cases invoked by a `keystone-manage` command? Otherwise this would be done through the HTTP API.

[Lance Bragstad (lbragstad)]

Hi Daniel,

In some of these cases, where do you expect the error number to be (logs, exception in the API response, etc)?

I see one of the places we use this exception is establishing connections with LDAP backends, which might be hit when starting keystone or on first authentication.

[Launchpad Janitor (janitor)]

[Expired for OpenStack Identity (keystone) because there has been no activity for 60 days.]