Assignment API doesn't test GET for member urls

Bug #1703245 reported by Lance Bragstad
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Yaroslav Telishevskiy

Bug Description

The assignment API implements HEAD for all GET operations [0]. The unit tests for the assignment API never test that GET actually works with the member_url, only the collection_url [1].

This path should be tested.

[0] https://github.com/openstack/keystone/blob/805b42ac4eaf47be76128f3a0fd89b878860f1ad/keystone/assignment/routers.py#L112
[1] https://github.com/openstack/keystone/blob/805b42ac4eaf47be76128f3a0fd89b878860f1ad/keystone/tests/unit/test_v3_assignment.py#L101-L130

tags: added: low-hanging-fruit office-hours test-improvement
Changed in keystone:
status: New → Triaged
importance: Undecided → Medium
Colin Best (cbest47)
Changed in keystone:
assignee: nobody → Colin Best (cbest47)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/499977

Changed in keystone:
assignee: Colin Best (cbest47) → Yaroslav Telishevskiy (yaroslavmt)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/499977
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=3dc593307de202532e1d438a7c65d661892c979e
Submitter: Jenkins
Branch: master

commit 3dc593307de202532e1d438a7c65d661892c979e
Author: yaroslavmt <email address hidden>
Date: Fri Sep 1 07:21:19 2017 -0400

    Add test GET for member url in the Assignment API

    Also add test GET and HEAD requests member_url for tests with not exist user.

    Change-Id: I00b40026bd2893e7976d97482ea06ba2b056935f
    Closes-Bug: #1703245

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 13.0.0.0b1

This issue was fixed in the openstack/keystone 13.0.0.0b1 development milestone.

Changed in keystone:
milestone: none → queens-1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.