"openstack role create" should support "--description"

Bug #1669080 reported by Guang Yee on 2017-03-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Wishlist
Deepak Mourya
python-openstackclient
In Progress
Undecided
Deepak Mourya

Bug Description

It would be nice to be able to create a new role with description as Keystone API supports it.

openstack role create --help
usage: openstack role create [-h] [-f {json,shell,table,value,yaml}]
                             [-c COLUMN] [--max-width <integer>]
                             [--print-empty] [--noindent] [--prefix PREFIX]
                             [--domain <domain>] [--or-show]
                             <role-name>

M V P Nitesh (m-nitesh) on 2017-06-08
Changed in python-openstackclient:
assignee: nobody → M V P Nitesh (m-nitesh)
Steve Martinelli (stevemar) wrote :

This sounds reasonable from a CLI point of view, but I don't recall if keystone roles have a description attribute for both v2 and v3. Adding keystone as a related project.

Lance Bragstad (lbragstad) wrote :

In order to implement this in keystone, we'd need a migration to add a new column to the role table. Right now only id, name, domain_id, and extras are persisted in the role table [0].

[0] https://github.com/openstack/keystone/blob/a43d5a6893a5753f8567206032e779930ddd4321/keystone/assignment/role_backends/sql.py#L196

tags: added: office-hours
Changed in keystone:
status: New → Triaged
importance: Undecided → Wishlist
Lance Bragstad (lbragstad) wrote :

Since we're getting close the Pike release this might be a good thing to fix as soon as Queens opens for development, especially since it requires a database migration.

M V P Nitesh (m-nitesh) on 2017-07-14
Changed in keystone:
assignee: nobody → M V P Nitesh (m-nitesh)
Lance Bragstad (lbragstad) wrote :

Hi m-nitesh,

I just missed your ping on IRC. We have documentation that explains how to add and sync your database [0]. If you have any questions, please feel free to come find me in #openstack-keystone.

Thanks for picking up the bug!

[0] https://docs.openstack.org/keystone/latest/devref/development_best_practices.html

Fix proposed to branch: master
Review: https://review.openstack.org/484348

Changed in keystone:
status: Triaged → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/484355

Changed in python-openstackclient:
status: New → In Progress
Lance Bragstad (lbragstad) wrote :

Targeting this to pike-3, which is this week. If we don't land it by the end of the week, we'll wait for Queens to open for development.

Changed in keystone:
milestone: none → pike-3
Changed in keystone:
milestone: pike-3 → pike-rc1
milestone: pike-rc1 → pike-3
Lance Bragstad (lbragstad) wrote :

Removing this from pike-3 (which has passed) since it is unlikely to land by the time we have to cut the rc candidate. We'll re-target this work for Queens.

Changed in keystone:
milestone: pike-3 → none
Changed in keystone:
assignee: M V P Nitesh (m-nitesh) → wangxiyuan (wangxiyuan)
Lance Bragstad (lbragstad) wrote :

Automatically unassigning due to inactivity.

Changed in keystone:
assignee: wangxiyuan (wangxiyuan) → nobody
Changed in python-openstackclient:
assignee: M V P Nitesh (m-nitesh) → nobody
Changed in keystone:
assignee: nobody → Deepak Mourya (mourya007)
Changed in python-openstackclient:
assignee: nobody → Deepak Mourya (mourya007)

Reviewed: https://review.openstack.org/484348
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=430d7f765a75830ae377545bc57195d38e44e172
Submitter: Zuul
Branch: master

commit 430d7f765a75830ae377545bc57195d38e44e172
Author: M V P Nitesh <email address hidden>
Date: Mon Aug 7 18:41:35 2017 +0530

    Added support for a ``description`` attribute for Identity Roles

    Now user can add the description to the role when user creates the role.
    Added support for a ``description`` attribute for V3 Identity Roles.

    Co-Authored-By: wangxiyuan<email address hidden>
    Co-Authored-By: Deepak Mourya<email address hidden>
    Change-Id: I230af9cc833af13064636b5d9a7ce6334c3f6e9a
    Closes-Bug: #1669080

Changed in keystone:
status: In Progress → Fix Released

This issue was fixed in the openstack/keystone 15.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers