Difference in Implied Roles check API return code

[Rodrigo Duarte]

The Implied Roles check API (HEAD /v3/roles/<role_id>/implies/<role_id>) returns 200 in Ubuntu Trusty and 204 in Ubuntu Xenial, check the jobs results at [1] (both running latest master):

- example of output in ubuntu-trusty job:

http://logs.openstack.org/82/426882/1/check/gate-tempest-dsvm-neutron-full-ubuntu-trusty/d4f9ec8/console.html#_2017-01-30_20_11_54_895227

This bug is not related if returning a 200 or 204 is correct for the given API, but related to the difference between two Ubuntu versions. Additionally, this specific API doesn't use the "wsgi.render_response" method [2] - others APIs that use this method (check grant, for example) don't have this problem.

[1] https://review.openstack.org/#/c/426882/
[2] https://github.com/openstack/keystone/blob/aeb51c84bb92d02715208aa8435aa3fd36564c72/keystone/assignment/controllers.py#L518-L519

[Steve Martinelli (stevemar)]

Do we have a list of methods that are incorrectly returning 200 instead of 204 in keystone?

From the test "Unexpected http success status code 200, The expected status code is 204"

[Steve Martinelli (stevemar)]

This will have to be fixed once we implement microversions. Which is on the table for Pike.

[Morgan Fainberg (mdrnstm)]

This is resolved by the conversion to flask. All returns if 204 are explicit. New code location and the explicit 204.

https://github.com/openstack/keystone/blob/e06302afa7db35234d680b4dce77fd27b269af47/keystone/api/roles.py#L211-L225

[Morgan Fainberg (mdrnstm)]

Marking as "invalid" now.