Reuse already registered group in tempest config

Bug #1659596 reported by Nishant Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Wishlist
Nishant Kumar

Bug Description

Instead of registering new groups in tempest plugin use the already registered group since the tempest config which is being used in plugin is the same as the upstream tempest. Also registering the same group twice would lead to duplicate opt error.

Changed in keystone:
assignee: nobody → Nishant Kumar (nishant-tech07)
Revision history for this message
Steve Martinelli (stevemar) wrote :

please include steps to recreate the error, or put up a patch if you're going to assign it to yourself with minimal info

Changed in keystone:
status: New → Incomplete
assignee: Nishant Kumar (nishant-tech07) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/426078

Changed in keystone:
assignee: nobody → Nishant Kumar (nishant-tech07)
status: Incomplete → In Progress
Revision history for this message
Samuel de Medeiros Queiroz (samueldmq) wrote :

Steve, I do not think there is an error here, it is all about a refactoring to make re-use of tempest code.

Changed in keystone:
importance: Undecided → Wishlist
Revision history for this message
Rodrigo Duarte (rodrigodsousa) wrote :

We are reusing settings from tempest, which is wrong, they can remove whenever they want (only tempest.lib is supposed to be stable). Ideally, we need to duplicate these settings, but since we are using the same names, this looks fine for now.

Changed in keystone:
milestone: none → ocata-rc1
Revision history for this message
Nishant Kumar (nishant-tech07) wrote :

Just an FYI http://docs.openstack.org/developer/tempest/plugin.html this states that tempest.config is also stable and since we are using the same tempest configuration object used in upstream tempest in plugin tests we should make use of any group which is already registered instead of creating the same group in plugin.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/426078
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=d6a05f568d6e63ac16d20a10292998745812d453
Submitter: Jenkins
Branch: master

commit d6a05f568d6e63ac16d20a10292998745812d453
Author: Nishant Kumar <email address hidden>
Date: Fri Jan 27 01:05:10 2017 -0500

    Reuse already existing groups from upstream tempest config

    Tempest plugin tests uses the same config file/object from the
    upstream tempest, therefore instead of registering the same group
    again in plugin tests we should reuse already existing groups and
    register only plugin specific option here.

    Change-Id: I948fdcf20732b98d5ba5d34fe0352ea9cff59f91
    Closes-Bug: #1659596

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 11.0.0.0rc1

This issue was fixed in the openstack/keystone 11.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.