| 2017-01-20 15:04:38 |
Ron De Rose |
bug |
|
|
added bug |
| 2017-01-20 15:05:20 |
Ron De Rose |
description |
We seen a couple instances now where the wrong migration step is run in tests when the migration file names in each repo are the same. For example, in the following patch, expand was called, yet the contract file was the one actually run:
Traceback (most recent call last):
File "keystone/tests/unit/test_sql_upgrade.py", line 1964, in test_migration_013_add_domain_id_to_user
self.expand(13)
File "keystone/tests/unit/test_sql_upgrade.py", line 228, in expand
self.repos[EXPAND_REPO].upgrade(*args, **kwargs)
File "keystone/common/sql/upgrades.py", line 63, in upgrade
self.schema_.runchange(ver, change, changeset.step)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/migrate/versioning/schema.py", line 93, in runchange
change.run(self.engine, step)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/migrate/versioning/script/py.py", line 148, in run
script_func(engine)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/keystone/common/sql/contract_repo/versions/013_add_domain_id_to_user.py", line 43, in upgrade
migrate.UniqueConstraint(user.c.id, user.c.domain_id,
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/sqlalchemy/util/_collections.py", line 212, in __getattr__
raise AttributeError(key)
AttributeError: domain_id
http://logs.openstack.org/74/409874/29/check/gate-keystone-python27-db-ubuntu-xenial/d2a60fd/testr_results.html.gz
Likewise, morgan was seeing a similar issue here, where the expand migration file wasn't being run, so the test failed the table exist check:
https://review.openstack.org/#/c/422817/3/keystone/tests/unit/test_sql_upgrade.py
However, both patches would run successfully locally.
As a workaround, making the repo file names unique fixes the problem, suggesting that perhaps this is related to the files being cached. |
We've seen a couple instances now where the wrong migration step is run in tests when the migration file names in each repo are the same. For example, in the following patch, expand was called, yet the contract file was the one actually run:
Traceback (most recent call last):
File "keystone/tests/unit/test_sql_upgrade.py", line 1964, in test_migration_013_add_domain_id_to_user
self.expand(13)
File "keystone/tests/unit/test_sql_upgrade.py", line 228, in expand
self.repos[EXPAND_REPO].upgrade(*args, **kwargs)
File "keystone/common/sql/upgrades.py", line 63, in upgrade
self.schema_.runchange(ver, change, changeset.step)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/migrate/versioning/schema.py", line 93, in runchange
change.run(self.engine, step)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/migrate/versioning/script/py.py", line 148, in run
script_func(engine)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/keystone/common/sql/contract_repo/versions/013_add_domain_id_to_user.py", line 43, in upgrade
migrate.UniqueConstraint(user.c.id, user.c.domain_id,
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/sqlalchemy/util/_collections.py", line 212, in __getattr__
raise AttributeError(key)
AttributeError: domain_id
http://logs.openstack.org/74/409874/29/check/gate-keystone-python27-db-ubuntu-xenial/d2a60fd/testr_results.html.gz
Likewise, morgan was seeing a similar issue here, where the expand migration file wasn't being run, so the test failed the table exist check:
https://review.openstack.org/#/c/422817/3/keystone/tests/unit/test_sql_upgrade.py
However, both patches would run successfully locally.
As a workaround, making the repo file names unique fixes the problem, suggesting that perhaps this is related to the files being cached. |
|
| 2017-01-20 15:06:15 |
Ron De Rose |
description |
We've seen a couple instances now where the wrong migration step is run in tests when the migration file names in each repo are the same. For example, in the following patch, expand was called, yet the contract file was the one actually run:
Traceback (most recent call last):
File "keystone/tests/unit/test_sql_upgrade.py", line 1964, in test_migration_013_add_domain_id_to_user
self.expand(13)
File "keystone/tests/unit/test_sql_upgrade.py", line 228, in expand
self.repos[EXPAND_REPO].upgrade(*args, **kwargs)
File "keystone/common/sql/upgrades.py", line 63, in upgrade
self.schema_.runchange(ver, change, changeset.step)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/migrate/versioning/schema.py", line 93, in runchange
change.run(self.engine, step)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/migrate/versioning/script/py.py", line 148, in run
script_func(engine)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/keystone/common/sql/contract_repo/versions/013_add_domain_id_to_user.py", line 43, in upgrade
migrate.UniqueConstraint(user.c.id, user.c.domain_id,
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/sqlalchemy/util/_collections.py", line 212, in __getattr__
raise AttributeError(key)
AttributeError: domain_id
http://logs.openstack.org/74/409874/29/check/gate-keystone-python27-db-ubuntu-xenial/d2a60fd/testr_results.html.gz
Likewise, morgan was seeing a similar issue here, where the expand migration file wasn't being run, so the test failed the table exist check:
https://review.openstack.org/#/c/422817/3/keystone/tests/unit/test_sql_upgrade.py
However, both patches would run successfully locally.
As a workaround, making the repo file names unique fixes the problem, suggesting that perhaps this is related to the files being cached. |
We've seen a couple instances now where the wrong migration step is run in tests, when the migration file names in each repo are the same. For example, in the following patch, expand was called, yet the contract file was the one actually run:
Traceback (most recent call last):
File "keystone/tests/unit/test_sql_upgrade.py", line 1964, in test_migration_013_add_domain_id_to_user
self.expand(13)
File "keystone/tests/unit/test_sql_upgrade.py", line 228, in expand
self.repos[EXPAND_REPO].upgrade(*args, **kwargs)
File "keystone/common/sql/upgrades.py", line 63, in upgrade
self.schema_.runchange(ver, change, changeset.step)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/migrate/versioning/schema.py", line 93, in runchange
change.run(self.engine, step)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/migrate/versioning/script/py.py", line 148, in run
script_func(engine)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/keystone/common/sql/contract_repo/versions/013_add_domain_id_to_user.py", line 43, in upgrade
migrate.UniqueConstraint(user.c.id, user.c.domain_id,
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/sqlalchemy/util/_collections.py", line 212, in __getattr__
raise AttributeError(key)
AttributeError: domain_id
http://logs.openstack.org/74/409874/29/check/gate-keystone-python27-db-ubuntu-xenial/d2a60fd/testr_results.html.gz
Likewise, morgan was seeing a similar issue here, where the expand migration file wasn't being run, so the test failed the table exist check:
https://review.openstack.org/#/c/422817/3/keystone/tests/unit/test_sql_upgrade.py
However, both patches would run successfully locally.
As a workaround, making the repo file names unique fixes the problem, suggesting that perhaps this is related to the files being cached. |
|
| 2017-01-20 15:12:54 |
Ron De Rose |
description |
We've seen a couple instances now where the wrong migration step is run in tests, when the migration file names in each repo are the same. For example, in the following patch, expand was called, yet the contract file was the one actually run:
Traceback (most recent call last):
File "keystone/tests/unit/test_sql_upgrade.py", line 1964, in test_migration_013_add_domain_id_to_user
self.expand(13)
File "keystone/tests/unit/test_sql_upgrade.py", line 228, in expand
self.repos[EXPAND_REPO].upgrade(*args, **kwargs)
File "keystone/common/sql/upgrades.py", line 63, in upgrade
self.schema_.runchange(ver, change, changeset.step)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/migrate/versioning/schema.py", line 93, in runchange
change.run(self.engine, step)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/migrate/versioning/script/py.py", line 148, in run
script_func(engine)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/keystone/common/sql/contract_repo/versions/013_add_domain_id_to_user.py", line 43, in upgrade
migrate.UniqueConstraint(user.c.id, user.c.domain_id,
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/sqlalchemy/util/_collections.py", line 212, in __getattr__
raise AttributeError(key)
AttributeError: domain_id
http://logs.openstack.org/74/409874/29/check/gate-keystone-python27-db-ubuntu-xenial/d2a60fd/testr_results.html.gz
Likewise, morgan was seeing a similar issue here, where the expand migration file wasn't being run, so the test failed the table exist check:
https://review.openstack.org/#/c/422817/3/keystone/tests/unit/test_sql_upgrade.py
However, both patches would run successfully locally.
As a workaround, making the repo file names unique fixes the problem, suggesting that perhaps this is related to the files being cached. |
We've seen a couple instances now where the wrong migration step is run in tests, when the migration file names in each repo are the same. For example, in the following patch, expand was called, yet the contract file was the one actually run:
Traceback (most recent call last):
File "keystone/tests/unit/test_sql_upgrade.py", line 1964, in test_migration_013_add_domain_id_to_user
self.expand(13)
File "keystone/tests/unit/test_sql_upgrade.py", line 228, in expand
self.repos[EXPAND_REPO].upgrade(*args, **kwargs)
File "keystone/common/sql/upgrades.py", line 63, in upgrade
self.schema_.runchange(ver, change, changeset.step)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/migrate/versioning/schema.py", line 93, in runchange
change.run(self.engine, step)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/migrate/versioning/script/py.py", line 148, in run
script_func(engine)
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/keystone/common/sql/contract_repo/versions/013_add_domain_id_to_user.py", line 43, in upgrade
migrate.UniqueConstraint(user.c.id, user.c.domain_id,
File "/home/jenkins/workspace/gate-keystone-python27-db-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/sqlalchemy/util/_collections.py", line 212, in __getattr__
raise AttributeError(key)
AttributeError: domain_id
http://logs.openstack.org/74/409874/29/check/gate-keystone-python27-db-ubuntu-xenial/d2a60fd/testr_results.html.gz
Likewise, morgan was seeing a similar issue here, where the expand migration file wasn't being run, so the test failed the table exist check:
https://review.openstack.org/#/c/422817/3/keystone/tests/unit/test_sql_upgrade.py
http://eavesdrop.openstack.org/irclogs/%23openstack-keystone/%23openstack-keystone.2017-01-20.log.html
However, both patches would run successfully locally.
As a workaround, making the repo file names unique fixes the problem, suggesting that perhaps this is related to the files being cached. |
|
| 2017-01-20 15:13:46 |
Ron De Rose |
keystone: assignee |
|
Ron De Rose (ronald-de-rose) |
|
| 2017-01-20 15:25:13 |
Dolph Mathews |
bug |
|
|
added subscriber Dolph Mathews |
| 2017-01-20 15:32:22 |
Lance Bragstad |
tags |
|
sql |
|
| 2017-01-20 16:31:29 |
Dolph Mathews |
keystone: importance |
Undecided |
High |
|
| 2017-01-20 19:17:11 |
Steve Martinelli |
tags |
sql |
sql test-improvement |
|
| 2017-02-06 22:48:22 |
OpenStack Infra |
keystone: status |
New |
In Progress |
|
| 2017-02-28 15:18:24 |
OpenStack Infra |
keystone: status |
In Progress |
Fix Released |
|
| 2017-03-01 22:48:50 |
Lance Bragstad |
keystone: milestone |
|
pike-1 |
|
