Exception don't follow a punctuation convention

Bug #1656026 reported by Lance Bragstad
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Gage Hugo

Bug Description

If you happen to take a look through keystone exception module [0]. You'll notice that some of the exceptions use proper punctuation, while other do not. David Stanek mentioned this in a review [1], and we thought it was appropriate to track it as a low-hanging-fruit bug.

We should decide what that convention should be for keystone, then apply it to all of our exceptions consistently.

[0] https://github.com/openstack/keystone/blob/f8ee249bf08cefd8468aa15c589dab48bd5c4cd8/keystone/exception.py#L105-L118
[1] https://review.openstack.org/#/c/415895/8/keystone/exception.py

description: updated
tags: added: low-hanging-fruit
Gage Hugo (gagehugo)
Changed in keystone:
assignee: nobody → Gage Hugo (gagehugo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/420187

Changed in keystone:
status: New → In Progress
Changed in keystone:
importance: Undecided → Low
milestone: none → ocata-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/420187
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=ee2747bac2e6eeb86e6340a2bb3509bc25f115bc
Submitter: Jenkins
Branch: master

commit ee2747bac2e6eeb86e6340a2bb3509bc25f115bc
Author: Gage Hugo <email address hidden>
Date: Fri Jan 13 15:34:59 2017 -0600

    Corrected punctuation on multiple exceptions

    As mentioned in the bug report, keystone/exceptions.py has many
    exceptions with messages that are not consistant with each other
    and have various punctuational differences, such as some ending
    with a period while others do not.

    This change adds a '.' to the end of many exception messages and
    adds small changes to other messages in order to keep all of the
    exception messages consistant.

    Change-Id: I21cac56ff70dbc2693c6090b887537a7c1f303e1
    Closes-Bug: #1656026

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 11.0.0.0b3

This issue was fixed in the openstack/keystone 11.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.