token model assumes a token is is_admin_project

Bug #1652012 reported by Henry Nash on 2016-12-22
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Low
Unassigned

Bug Description

Our token model code will return a default of True for is_admin_project if that attribute is not defined [0]. The comment next to this says this is for backward compatibility - but this seems inherently dangerous. We should investigate what changes are needed (if any) to make the default False.

UPDATE: We need this to default to True for the time being while we deal
with #968696. Do not change this to False at this time.

[0] https://github.com/openstack/keystone/blob/686f9d583eaa5f015d6b8b995c2f4243392ffbce/keystone/models/token_model.py#L195-L198

description: updated
Changed in keystone:
status: New → Confirmed
importance: Undecided → Low
Gage Hugo (gagehugo) on 2017-03-02
Changed in keystone:
assignee: nobody → Gage Hugo (gagehugo)
Changed in keystone:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/438035
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=dc449dfd63c165cfa9c4600b82e5b392973a0e60
Submitter: Jenkins
Branch: master

commit dc449dfd63c165cfa9c4600b82e5b392973a0e60
Author: Gage Hugo <email address hidden>
Date: Fri Feb 24 12:26:41 2017 -0600

    Change is_admin_project to False by default

    Our token model code will return a default of True for
    is_admin_project if that attribute is not defined. The
    comment next to this says this is for backwards
    compatibility, but this seems inherently dangerous.

    Closes-Bug: #1652012

    Change-Id: I035fe570972764b9c9342d1851654634d681ac5e

Changed in keystone:
status: In Progress → Fix Released
Changed in keystone:
milestone: none → pike-1

This issue was fixed in the openstack/keystone 12.0.0.0b1 development milestone.

Adam Young (ayoung) wrote :

This was a mistake.

Lance Bragstad (lbragstad) wrote :
Changed in keystone:
status: Fix Released → In Progress
milestone: pike-1 → none
Gage Hugo (gagehugo) on 2017-05-16
description: updated
Changed in keystone:
status: In Progress → Triaged
Lance Bragstad (lbragstad) wrote :

Unassigning due to inactivity.

Changed in keystone:
assignee: Gage Hugo (gagehugo) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers