enable CADF notification format by default

Bug #1641660 reported by Steve Martinelli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Tin Lam

Bug Description

The current default notification format is the home-brewed openstack-styled format, that provides minimal information about the user. For a few releases now, all new notifications have adhered to the CADF format. We should switch over to the CADF format, which provides compatibility with the order format.

Additionally, we probably want to squelch authentication messages, since there has been feedback that it is too noisy.

Implementation wise, this would mean the following changes to the default config file:

  [default] ``notification_format=cadf``
  [default] ``notification_opt_out=identity.authenticate.success``
  [default] ``notification_opt_out=identity.authenticate.pending``
  [default] ``notification_opt_out=identity.authenticate.failed``

Tin Lam (lamt)
Changed in keystone:
assignee: nobody → Tin Lam (tl3438)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/397339

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to keystone (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/399937

Changed in keystone:
assignee: Tin Lam (tl3438) → Steve Martinelli (stevemar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/399938

Changed in keystone:
assignee: Steve Martinelli (stevemar) → Tin Lam (tl3438)
Changed in keystone:
assignee: Tin Lam (tl3438) → Steve Martinelli (stevemar)
Changed in keystone:
assignee: Steve Martinelli (stevemar) → Tin Lam (tl3438)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to keystone (master)

Reviewed: https://review.openstack.org/399937
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=5a930e7a63a025a93d1007e75784cb5233f43631
Submitter: Jenkins
Branch: master

commit 5a930e7a63a025a93d1007e75784cb5233f43631
Author: Tin Lam <email address hidden>
Date: Sun Nov 20 01:49:30 2016 -0500

    refactor notification test to work with either format

    The _test_notification_operation function only works with the
    `basic` notification format.

    For the `cadf` format to work, it is necessary to mock the
    _create_cadf_payload call.

    Change-Id: I982fcead0f6cb89a13057ee5275087d2e32612cc
    Related-Bug: #1641660

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/397339
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=165e5a98f02e3cbad52c6c65989b83841f89de19
Submitter: Jenkins
Branch: master

commit 165e5a98f02e3cbad52c6c65989b83841f89de19
Author: Tin Lam <email address hidden>
Date: Sun Nov 20 01:54:29 2016 -0500

    Enable CADF notification format by default

    The current default notification format is set to ``basic``, the home-brewed
    openstack-styled format. Since all new notifications have adhered to the
    CADF format, we should switch to use CADF format by default, which provides
    compatibility with the older format.

    Also, messages for the following authentication events are squelched due
    to their chattiness:

    * identity.authenticate.success
    * identity.authenticate.pending
    * identity.authenticate.failed

    Change-Id: I6dd3a52319bd59aa5ef856e6d99b5a1d7c37e371
    Closes-Bug: #1641660

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to keystone (master)

Reviewed: https://review.openstack.org/399938
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=eeaa4d726e6ad5947af55f8be7e49570a5e92086
Submitter: Jenkins
Branch: master

commit eeaa4d726e6ad5947af55f8be7e49570a5e92086
Author: Tin Lam <email address hidden>
Date: Sun Nov 20 01:54:53 2016 -0500

    Swap the notification formats in the docs

    The default notification format should be the one the user
    reads first. Swap the CADF format and the basic one around.

    Change-Id: I7adeb94e1233dafead62ee8b2a9d4f2cda8b22db
    Related-Bug: 1641660

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 11.0.0.0b2

This issue was fixed in the openstack/keystone 11.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.