OpenStack Identity (keystone)

keystone.contrib.ec2.controllers.Ec2Controller is untested

Bug #1635389 reported by Lance Bragstad
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Jose Castro Leon
OpenStack Identity (keystone) pike-rc1 "pike-rc1"
Ocata
Fix Committed
Medium
Unassigned

Bug Description

The Ec2Controller controller is completely untested. I can break interfaces in keystone that controller relies on and all the tests still pass.

Lance Bragstad (lbragstad)
tags: added: test-improvement
Steve Martinelli (stevemar)
Changed in keystone:
importance: Undecided → Medium
Anthony Washington (anthony-washington)
Changed in keystone:
assignee: nobody → Anthony Washington (anthony-washington)
Anthony Washington (anthony-washington)
Changed in keystone:
assignee: Anthony Washington (anthony-washington) → nobody
Lance Bragstad (lbragstad)
Changed in keystone:
milestone: none → pike-3
status: New → Triaged
Lance Bragstad (lbragstad)
tags: added: office-hours
Lance Bragstad (lbragstad)
Changed in keystone:
milestone: pike-3 → pike-rc1
Revision history for this message
Lance Bragstad (lbragstad) wrote :

We have a patch in flight to add the tests here - https://review.openstack.org/#/c/465530/3

Changed in keystone:
assignee: nobody → Jose Castro Leon (jose-castro-leon)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/465530
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=820d9d9a84f2a65677a2654b36a4677eaeba59fc
Submitter: Jenkins
Branch: master

commit 820d9d9a84f2a65677a2654b36a4677eaeba59fc
Author: Jose Castro Leon <email address hidden>
Date: Wed May 17 14:00:34 2017 +0200

    Fix ec2tokens validation in v2 after regression in metadata_ref removal

    Since the last patch in the ocata release that removed the metadata_ref,
    the ec2tokens api is broken due to unable to unpack the result of the
    authenticate command (4 elements) while expecting to expand it into 5.

    Change-Id: I71c4b51444ea9f7a3016b68d7dee9a4747e9c0fd
    Closes-Bug: #1691111
    Closes-Bug: #1635389

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 12.0.0.0rc1

This issue was fixed in the openstack/keystone 12.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/507434

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (stable/ocata)

Reviewed: https://review.openstack.org/507434
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=e1a94f39edb6cf777c71c7a511476b1e60436ab9
Submitter: Jenkins
Branch: stable/ocata

commit e1a94f39edb6cf777c71c7a511476b1e60436ab9
Author: Jose Castro Leon <email address hidden>
Date: Wed May 17 14:00:34 2017 +0200

    Fix ec2tokens validation in v2 after regression in metadata_ref removal

    Since the last patch in the ocata release that removed the metadata_ref,
    the ec2tokens api is broken due to unable to unpack the result of the
    authenticate command (4 elements) while expecting to expand it into 5.

    Change-Id: I71c4b51444ea9f7a3016b68d7dee9a4747e9c0fd
    Closes-Bug: #1691111
    Closes-Bug: #1635389
    (cherry picked from commit 820d9d9a84f2a65677a2654b36a4677eaeba59fc)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 11.0.4

This issue was fixed in the openstack/keystone 11.0.4 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.