Make validation patterns configurable

Bug #1599546 reported by Lance Bragstad on 2016-07-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Low
Unassigned

Bug Description

Keystone now treats configuration like a module, making it easier to enforce import order without race conditions[0]. There are a few TODOs to make certain validation patterns configurable. With the way configuration was being handled before, we were unable to import values from configuration on import. Now that configuration is referenced like a module-level package, we can avoid those race conditions. By making validation configurable we'll allow operators/deployers to choose how strict they wish to validate specific types [1][2].

[0] https://github.com/openstack/keystone/commit/d9c6b50a3ae514e640fa13a344e59fe3649ee0ef
[1] https://github.com/openstack/keystone/blob/46b76a3d8e302f47daf04c739066f70b7438e0da/keystone/common/validation/parameter_types.py#L42-L43
[2] https://github.com/openstack/keystone/blob/46b76a3d8e302f47daf04c739066f70b7438e0da/keystone/common/validation/parameter_types.py#L62-L64

Changed in keystone:
importance: Undecided → Wishlist
Changed in keystone:
importance: Wishlist → Low
Changed in keystone:
assignee: nobody → Lance Bragstad (lbragstad)
status: New → In Progress
Lance Bragstad (lbragstad) wrote :

Automatically unassigning due to inactivity. WIP patch is up for review in case anyone has the bandwidth to pick this up [0].

[0] https://review.openstack.org/#/c/334673/

Changed in keystone:
assignee: Lance Bragstad (lbragstad) → nobody
Lance Bragstad (lbragstad) wrote :

I have a series of patches that clean up the token provider API [0]. Chances are this bug could be fixes as a result.

[0] https://review.openstack.org/#/q/status:open+project:openstack/keystone+branch:master+topic:cleanup-token-provider

Lance Bragstad (lbragstad) wrote :

Disregard - I commented on the wrong patch.

Change abandoned by Lance Bragstad (<email address hidden>) on branch: master
Review: https://review.openstack.org/334673
Reason: Abandoning this for now.

Morgan Fainberg (mdrnstm) wrote :

Marking as invalid. Validation should not vary based upon options set in configuration keystone-to-keystone. It makes it hard to know what to expect when interacting with keystone.

Changed in keystone:
status: In Progress → Opinion
Yang Youseok (ileixe) wrote :

I found this patch looking for configurable schema validation in openstack codebase. Although schema is quite a bit static data, we got requests from operators many times at least to restrict resources' name. (e.g. server name with no underbar, project name only with english...). So, adding configurable schema is good place to start with our requirements and I wonder community does not purse on it.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers