return `revoked_at` for the revocation event

Bug #1598040 reported by Dave Chen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Dave Chen

Bug Description

Currently, the `revoked_at` is not returned when the API of getting revocation events are executed, the `revoked_at` is always available in the backends, get back this to the end user will help to give us the clue on what happened and when the token was revoked, especially, if the `issued_before` is set with a different time compared with `revoked_at`.

Steps to reproduce,
1. create a token.
2. delete the token.
3. list revoke events.

The sample output as follow,
{"events": [{"issued_before": "2016-06-27T06:12:52.000000Z", "audit_id": "MwPMflshThm7zj7lGcWOnQ"}, {"issued_before": "2016-06-27T07:35:31.000000Z", "audit_id": "nJpSKrzUQLq-jjygqvB-sA"}], "links": {"self": "http://10.239.159.68/identity/v3/OS-REVOKE/events", "previous": null, "next": null}}

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/336439

Changed in keystone:
assignee: nobody → Dave Chen (wei-d-chen)
status: New → In Progress
Changed in keystone:
importance: Undecided → Medium
milestone: none → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to keystone (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/336963

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/336439
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=25e5227d23d7b8e1b2969a6b7dd6da4fe50972a4
Submitter: Jenkins
Branch: master

commit 25e5227d23d7b8e1b2969a6b7dd6da4fe50972a4
Author: Dave Chen <email address hidden>
Date: Fri Jul 1 16:40:18 2016 +0800

    Return `revoked_at` for list revoke events

    The field will help to figure out when the event is recorded, and thus
    give a clue on when the revocation was done.

    Change-Id: If5ba3bb9b68fff5f35be2b57af15584d69c6df8d
    Closes-Bug: #1598040

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to keystone (master)

Reviewed: https://review.openstack.org/336963
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=b425379360438f6fea50d1e69c121ea65827800e
Submitter: Jenkins
Branch: master

commit b425379360438f6fea50d1e69c121ea65827800e
Author: Dave Chen <email address hidden>
Date: Mon Jul 4 08:53:27 2016 +0800

    Refactoring: remove the duplicate method

    The method `assertTimestampEqual` which compare two ISO 8601 format
    time can be used across the testcases, so move the method to core.py
    and remove the duplicate method.

    Change-Id: I7bd34380f87da0ee8a52af228f1cf966d90b33c8
    Related-Bug: #1598040

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/keystone 10.0.0.0b2

This issue was fixed in the openstack/keystone 10.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.