Named arguments should be used for assertValidUserResponse() in unittest case

[Andrew Liu]

In the keystone unittest of test_v3_identity.py, there are two functions used in the IdentityTestCase,
one is assertValidUserListResponse() and another is assertValidUserResponse().

These two functions eventually used this RestfulTestCase.assertValidUser(), and for the above two functions are call in different style.

self.assertValidUserListResponse(r, ref=self.user, resource_url=resource_url)
self.assertValidUserResponse(r, user)

the assertValidUserListResponse() is called with named argument "ref=self.user", but the assertValidUserResponse() is not.

Although, this won't cause any problem, but it would be better to unify the function call.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/328907

[David Stanek (dstanek)]

I'm marking this as opinion because I think it's better the way that it currently is, but I'd be open to changing my mind with a good argument. To me there is minimal benefit to making a change like this and it's definitely not a bug.

[Steve Martinelli (stevemar)]

I agree with your assessment, I will mark this as wishlist as it only impacts our tests

[Lance Bragstad (lbragstad)]

Automatically unassigning due to inactivity.

[Steve Martinelli (stevemar)]

No movement in months, there is no direct user impact here so I'm marking as invalid.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Steve Martinelli (<email address hidden>) on branch: master
Review: https://review.openstack.org/328907
Reason: no movement in months, and bug is marked as invalid, let's move on.