OpenStack Identity (keystone)

Move validate_non_persistent_token() method from base to fernet

Bug #1582493 reported by javeme
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Undecided
Unassigned

Bug Description

Full path of validate_non_persistent_token():
keystone.token.providers.common.BaseProvider.validate_non_persistent_token()

The validate_non_persistent_token() method is just for fernet, and there are
some variables/methods used that do not exist in the BaseProvider like:
  self.token_formatter
  self._rebuild_federated_info()
  self._rebuild_federated_token_roles()

So it is more suitable to move validate_non_persistent_token() to fernet.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/317211

Changed in keystone:
assignee: nobody → javeme (javaloveme)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by javeme (<email address hidden>) on branch: master
Review: https://review.openstack.org/317211

Revision history for this message
Lance Bragstad (lbragstad) wrote :

I have a series of patches that clean up the token provider API [0]. Chances are this bug could be fixes as a result.

[0] https://review.openstack.org/#/q/status:open+project:openstack/keystone+branch:master+topic:cleanup-token-provider

Changed in keystone:
assignee: javeme (javaloveme) → nobody
Revision history for this message
Steve Martinelli (stevemar) wrote :

Lance is correct.

Changed in keystone:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.