Incorrect deprecation warning for IdentityDriverV8

Bug #1569814 reported by Henry Nash
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Ron De Rose

Bug Description

Commit ad7a7bd6ee36a7af61f88d98038d83aba25a9743 (https://review.openstack.org/#/c/296140/) moved driver interfaces for core Identity into their own module (base.py in the backend directory). For compatibility it included a class definition of IdentityDriverV8 in the original location (core.py), with a deprecation warning.

@versionutils.deprecated(
    versionutils.deprecated.MITAKA,
    what='keystone.identity.IdentityDriverV8',
    in_favor_of='keystone.identity.backends.base.IdentityDriverV8',
    remove_in=+1)
class IdentityDriverV8(identity_interface.IdentityDriverV8):
    pass

There appear to be two things wrong with this:

1) I don't believe this merged for Mitaka. Hence we can't retrospectively start the deprecation in Mitaka
2) I thought we were committing to 2 cycles for deprecation in general.
[rderose] In general yes, but we agreed to do just 1 cycle for this change.

Hence I think this should be NEWTON + 2.
[rderose] NEWTON + 1

Changed in keystone:
assignee: nobody → Ron De Rose (ronald-de-rose)
Changed in keystone:
status: New → Confirmed
description: updated
Revision history for this message
Henry Nash (henry-nash) wrote :

Ok, didn't know about the agreement for 1 cycle for this..So agree with your proposal.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/305301

Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/305301
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=61ae6d725b8981e2cf0cbf86ff9e98bba6d53b9e
Submitter: Jenkins
Branch: master

commit 61ae6d725b8981e2cf0cbf86ff9e98bba6d53b9e
Author: Ronald De Rose <email address hidden>
Date: Wed Apr 13 14:10:48 2016 +0000

    Fixes incorrect deprecation warning for IdentityDriverV8

    This patch fixes incorrect deprecation warning for IdentityDriver8, as
    it was merged in NEWTON and not MITAKA.

    Closes-Bug: #1569814

    Change-Id: I4fd3b7bf28c35791ff4d14d4226e2a29a1243a0f

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/keystone 10.0.0.0b1

This issue was fixed in the openstack/keystone 10.0.0.0b1 development milestone.

Changed in keystone:
importance: Undecided → Medium
milestone: none → newton-1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.