Keystone unit test failure with oslo.* from master

Bug #1561121 reported by Davanum Srinivas (DIMS) on 2016-03-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Medium
Brant Knudson
Mitaka
Medium
Brant Knudson
Newton
Medium
Brant Knudson

Bug Description

from http://logs.openstack.org/periodic/periodic-keystone-py27-with-oslo-master/0665198/console.html#_2016-03-23_06_21_06_074

2016-03-23 06:21:06.073 | ==============================
2016-03-23 06:21:06.073 | Failed 1 tests - output below:
2016-03-23 06:21:06.073 | ==============================
2016-03-23 06:21:06.073 |
2016-03-23 06:21:06.073 | keystone.tests.unit.common.test_manager.TestCreateLegacyDriver.test_class_is_properly_deprecated
2016-03-23 06:21:06.073 | ------------------------------------------------------------------------------------------------
2016-03-23 06:21:06.074 |
2016-03-23 06:21:06.074 | Captured traceback:
2016-03-23 06:21:06.074 | ~~~~~~~~~~~~~~~~~~~
2016-03-23 06:21:06.074 | Traceback (most recent call last):
2016-03-23 06:21:06.074 | File "/home/jenkins/workspace/periodic-keystone-py27-with-oslo-master/.tox/py27-oslo-master/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
2016-03-23 06:21:06.074 | return func(*args, **keywargs)
2016-03-23 06:21:06.074 | File "keystone/tests/unit/common/test_manager.py", line 37, in test_class_is_properly_deprecated
2016-03-23 06:21:06.075 | mock_reporter.assert_called_with(mock.ANY, mock.ANY, details)
2016-03-23 06:21:06.075 | File "/home/jenkins/workspace/periodic-keystone-py27-with-oslo-master/.tox/py27-oslo-master/local/lib/python2.7/site-packages/mock/mock.py", line 937, in assert_called_with
2016-03-23 06:21:06.075 | six.raise_from(AssertionError(_error_message(cause)), cause)
2016-03-23 06:21:06.075 | File "/home/jenkins/workspace/periodic-keystone-py27-with-oslo-master/.tox/py27-oslo-master/local/lib/python2.7/site-packages/six.py", line 718, in raise_from
2016-03-23 06:21:06.075 | raise value
2016-03-23 06:21:06.075 | AssertionError: Expected call: report_deprecated_feature(<ANY>, <ANY>, {'in_favor_of': 'keystone.catalog.core.CatalogDriverV8', 'as_of': 'Liberty', 'what': 'keystone.catalog.core.Driver', 'remove_in': 'N'})
2016-03-23 06:21:06.076 | Actual call: report_deprecated_feature(<logging.Logger object at 0x7ff437f1b8d0>, u'%(what)s is deprecated as of %(as_of)s in favor of %(in_favor_of)s and may be removed in %(remove_in)s.', {'in_favor_of': 'keystone.catalog.core.CatalogDriverV8', 'as_of': 'Liberty', 'what': 'keystone.catalog.core.Driver', 'remove_in': 'Newton'})

Boris Bobrov (bbobrov) wrote :
Changed in keystone:
assignee: nobody → Boris Bobrov (bbobrov)
status: New → In Progress
Boris Bobrov (bbobrov) wrote :

I've removed myself from the "assigned to" because Brant actually proposed the patch.

Changed in keystone:
assignee: Boris Bobrov (bbobrov) → nobody
Changed in keystone:
importance: Undecided → Medium
assignee: nobody → Brant Knudson (blk-u)

Reviewed: https://review.openstack.org/291207
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=8556437ee02de028ec5de3b867abaab82533cb91
Submitter: Jenkins
Branch: master

commit 8556437ee02de028ec5de3b867abaab82533cb91
Author: Brant Knudson <email address hidden>
Date: Thu Mar 10 08:35:13 2016 -0600

    Correct test to support changing N release name

    oslo.log is going to change to use Newton rather than N so this test
    should not make an assumption about the way that
    versionutils.deprecated is calling report_deprecated_feature.

    Change-Id: I06aa6d085232376811f73597b2d84b5174bc7a8d
    Closes-Bug: 1561121

Changed in keystone:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/298241
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=685116d1a2799399819ed780679403e7576e67b5
Submitter: Jenkins
Branch: stable/mitaka

commit 685116d1a2799399819ed780679403e7576e67b5
Author: Brant Knudson <email address hidden>
Date: Thu Mar 10 08:35:13 2016 -0600

    Correct test to support changing N release name

    oslo.log is going to change to use Newton rather than N so this test
    should not make an assumption about the way that
    versionutils.deprecated is calling report_deprecated_feature.

    Change-Id: I06aa6d085232376811f73597b2d84b5174bc7a8d
    Closes-Bug: 1561121
    (cherry picked from commit 8556437ee02de028ec5de3b867abaab82533cb91)

tags: added: in-stable-mitaka

This issue was fixed in the openstack/keystone 9.0.0.0rc2 release candidate.

Download full text (7.8 KiB)

Reviewed: https://review.openstack.org/302567
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=a78623a456fc0a657a01aa5a887641f0b73d64a8
Submitter: Jenkins
Branch: master

commit 3e5fca06c6b7dd6060721faa39428b133edd10f0
Author: Boris Bobrov <email address hidden>
Date: Tue Apr 5 18:50:48 2016 +0300

    Update federated user display name with shadow_users_api

    When a user comes to the cloud for the first time, a shadow user is
    created. When the user authenticates again, this shadow user is
    fetched and returned. Before it is returned, its display name should
    be updated. But the call to update the display name fails because
    neither identity manager nor identity drivers have the required
    method. However, the required method exists in shadow_users_api.

    The issue was hidden because method shadow_federated_user was
    cached and while the cache lived, the user could authenticate.

    Use the method of shadow_user_api instead of identity_api to update
    federated user display name.

    Change-Id: I58e65bdf3a953f3ded485003939b81f908738e1e
    Closes-Bug: 1566282
    (cherry picked from commit 7ad4f8728cce354617b5facefe5076d65af311c6)

commit dba04cdd232ab72704df58cff791d52c1c99bc90
Author: Morgan Fainberg <email address hidden>
Date: Mon Mar 28 10:50:12 2016 -0700

    Correct `role_name` constraint dropping

    The `role_name` constraint was not properly dropped in some cases
    because the unique constraint was not consistently named. In all
    cases we must search for the constraint expected, not assume the
    name of the constraint will be consistent (especially from older
    installs that have been moved forward in releases).

    This change fixes migration 88, updates 96 (for backport to
    stable/mitaka) This is being overly cautious, but specifically
    is to handle the case where someone performed the upgrade and
    manually fixed the migration resulting in duplicated constraints
    in the role_table. Note that migration 100 was not backported since
    it was a placeholder migration.

    Conflicts:
        keystone/tests/unit/test_sql_upgrade.py

    Co-Authored-By: "Matthew Thode" <email address hidden>
    Change-Id: Ie0dc3d2449bace57d3e9323b281a2abd2ad0c983
    closes-bug: #1562934
    (cherry picked from commit 276e57e2083dcad8cbabf9aa9b3bd06c6079c415)

commit cf1fd9dad7d89d50a10ab204aa487663ea258988
Author: OpenStack Proposal Bot <email address hidden>
Date: Wed Mar 30 06:16:27 2016 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: Iff9556deb5ebb465c7124c120e7806774c517472

commit c4b08ed2522ee771331d53f153bda5098c9fb9f4
Author: OpenStack Proposal Bot <email address hidden>
Date: Tue Mar 29 06:52:52 2016 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: I1e81320c932549e38bade5ef8d885ef426990f40

commit dd38543bdc2a11...

Read more...

Reviewed: https://review.openstack.org/310038
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=9e9c442b83830edaf000fa8398f242ff4d28e6af
Submitter: Jenkins
Branch: stable/liberty

commit 9e9c442b83830edaf000fa8398f242ff4d28e6af
Author: Brant Knudson <email address hidden>
Date: Thu Mar 10 08:35:13 2016 -0600

    Correct test to support changing N release name

    oslo.log is going to change to use Newton rather than N so this test
    should not make an assumption about the way that
    versionutils.deprecated is calling report_deprecated_feature.

    Change-Id: I06aa6d085232376811f73597b2d84b5174bc7a8d
    Closes-Bug: 1561121
    (cherry picked from commit 8556437ee02de028ec5de3b867abaab82533cb91)

tags: added: in-stable-liberty

This issue was fixed in the openstack/keystone 8.1.2 release.

This issue was fixed in the openstack/keystone 10.0.0.0b1 development milestone.

This issue was fixed in the openstack/keystone 8.1.2 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers