OpenStack Identity (keystone)

keystone should convert host CONF.federation.trusted_dashboard to lower case before comparing

Bug #1538754 reported by apal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Roxana Gherle
OpenStack Identity (keystone) mitaka-3 "m3"

Bug Description

https://github.com/openstack/keystone/blob/master/keystone/federation/controllers.py#L272
keystone should convert it to lower case before comparing

It should not be case sensitive. Otherwise some uppercase hostname would fail to auth from browser etc.

Roxana Gherle (roxana-gherle)
Changed in keystone:
assignee: nobody → Roxana Gherle (roxana-gherle)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/273394

Changed in keystone:
status: New → In Progress
Steve Martinelli (stevemar)
Changed in keystone:
milestone: none → mitaka-3
importance: Undecided → Medium
OpenStack Infra (hudson-openstack)
Changed in keystone:
assignee: Roxana Gherle (roxana-gherle) → Guang Yee (guang-yee)
Steve Martinelli (stevemar)
Changed in keystone:
assignee: Guang Yee (guang-yee) → Roxana Gherle (roxana-gherle)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/273394
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=78c9ccc9eea34148364563508af6847481b9c9f4
Submitter: Jenkins
Branch: master

commit 78c9ccc9eea34148364563508af6847481b9c9f4
Author: Roxana Gherle <email address hidden>
Date: Thu Jan 28 00:11:02 2016 -0800

    Make WebSSO trusted_dashboard hostname case-insensitive

    Ensure the hostname in the trusted_dashboard config is lowercase
    to prevent failures when comparing against the origin query URL.

    Closes-Bug: #1538754
    Change-Id: I807a567e7d93c09c5c370065509c106b7d1c973b

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/281554

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (stable/liberty)

Reviewed: https://review.openstack.org/281554
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=c665080d4a700b6d92f29c40621d83bd7365de34
Submitter: Jenkins
Branch: stable/liberty

commit c665080d4a700b6d92f29c40621d83bd7365de34
Author: Roxana Gherle <email address hidden>
Date: Thu Jan 28 00:11:02 2016 -0800

    Make WebSSO trusted_dashboard hostname case-insensitive

    Ensure the hostname in the trusted_dashboard config is lowercase
    to prevent failures when comparing against the origin query URL.

    Conflicts:
            keystone/common/utils.py

    Closes-Bug: #1538754
    Change-Id: I807a567e7d93c09c5c370065509c106b7d1c973b
    (cherry picked from commit 78c9ccc9eea34148364563508af6847481b9c9f4)

tags: added: in-stable-liberty
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/keystone 9.0.0.0b3

This issue was fixed in the openstack/keystone 9.0.0.0b3 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/keystone 8.1.0

This issue was fixed in the openstack/keystone 8.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.