Fix trust test cases for redelegation and add test for impersonation

Bug #1538626 reported by Jorge Munoz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Jorge Munoz

Bug Description

Test under class TestTrustRedelegation in test_v3_auth.py do not test redelegation since trust are created with impersonation set to true. Also, no test class exist for testing impersonation.

Incorrect boolean value: https://github.com/openstack/keystone/blob/1e44004c4028bd314ea59a084d4c898e2815c9de/keystone/tests/unit/test_v3_auth.py#L2931

Changed in keystone:
assignee: nobody → Jorge Munoz (jorge-munoz)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/273232

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/273279

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by Jorge Munoz (<email address hidden>) on branch: master
Review: https://review.openstack.org/273232
Reason: Correct behavior

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/278163

Changed in keystone:
importance: Undecided → Low
milestone: none → mitaka-3
Revision history for this message
Steve Martinelli (stevemar) wrote :

not critical to mitaka3

Changed in keystone:
milestone: mitaka-3 → none
tags: added: test-improvement trusts
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by Jorge Munoz (<email address hidden>) on branch: master
Review: https://review.openstack.org/273279
Reason: In favor of: https://review.openstack.org/#/c/278163/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/278163
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=9ae8795643acb4612dd13c60ce29b15081c39b8d
Submitter: Jenkins
Branch: master

commit 9ae8795643acb4612dd13c60ce29b15081c39b8d
Author: Jorge Munoz <email address hidden>
Date: Wed Feb 10 00:29:00 2016 +0000

    Fix trust chain tests

    Since redelegation of trust is only allowed using impersonation,
    test under class TestTrustChain need to test redelegation with
    impersonation set true.

    Change-Id: Ifba25568e2b55df895377a3b1c9626844b735a7c
    Partial-Bug: 1538626

Revision history for this message
Steve Martinelli (stevemar) wrote :

i'm going to mark this as fix released since the patch merged. not sure why it is a partial fix.

Changed in keystone:
milestone: none → mitaka-rc1
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.