federation create_mapping signature and V9 wrapper incorrect

Bug #1533346 reported by Henry Nash on 2016-01-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
High
Henry Nash

Bug Description

The original abstract signature for the create_mapping() driver method was wrong in the federation manager in Liberty. This was then inadvertently copied to the V9wrapper when we created the V9 driver in Mitaka. This would cause V8 federation drivers to fail with Mitaka. The legacy testing did not cover all the CRUD tests, which is why this was not discovered when the V9 driver was created.

Henry Nash (henry-nash) on 2016-01-12
Changed in keystone:
importance: Undecided → High
assignee: nobody → Henry Nash (henry-nash)

Fix proposed to branch: master
Review: https://review.openstack.org/266559

Changed in keystone:
status: New → In Progress
Changed in keystone:
assignee: Henry Nash (henry-nash) → Steve Martinelli (stevemar)
Changed in keystone:
assignee: Steve Martinelli (stevemar) → Henry Nash (henry-nash)
milestone: none → mitaka-2

Reviewed: https://review.openstack.org/266559
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=50986a766e8c451c598318cd3ba1ea73fca15e96
Submitter: Jenkins
Branch: master

commit 50986a766e8c451c598318cd3ba1ea73fca15e96
Author: Henry Nash <email address hidden>
Date: Tue Jan 12 20:06:45 2016 +0000

    Fix incorrect signature in federation legacy V8 wrapper

    The abstract signature for the create_mapping driver method in the
    Liberty V8 driver interface was wrong, which was then inadvertently
    used to create the V9 wrapper. This fixes that issue and adds attitional
    legacy tests to ensure the federation V8 CRUD operations are covered.

    There are numerous other inconsistency in the docstrings of the
    federation abstract methods, these are resolved in a follow on patch.

    Closes-bug: #1533346

    Change-Id: I1d0aa2a652c681512e5268567b994ce3459e8eac

Changed in keystone:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers