| 2015-11-19 10:42:29 |
ChangBo Guo(gcb) |
bug |
|
|
added bug |
| 2015-11-19 10:42:36 |
ChangBo Guo(gcb) |
oslo.config: assignee |
|
ChangBo Guo(gcb) (glongwave) |
|
| 2016-01-01 18:53:15 |
LiuNanke |
bug task added |
|
rally |
|
| 2016-01-01 18:53:21 |
LiuNanke |
rally: assignee |
|
LiuNanke (nanke-liu) |
|
| 2016-01-01 19:08:10 |
OpenStack Infra |
rally: status |
New |
In Progress |
|
| 2016-01-03 10:51:12 |
LiuNanke |
bug task added |
|
keystone |
|
| 2016-01-03 10:52:19 |
LiuNanke |
keystone: assignee |
|
LiuNanke (nanke-liu) |
|
| 2016-01-03 11:03:24 |
OpenStack Infra |
keystone: status |
New |
In Progress |
|
| 2016-01-04 17:30:28 |
LiuNanke |
rally: status |
In Progress |
New |
|
| 2016-01-04 17:30:31 |
LiuNanke |
keystone: status |
In Progress |
New |
|
| 2016-01-04 20:50:37 |
Andriy Kurilin |
rally: status |
New |
Triaged |
|
| 2016-01-04 20:50:39 |
Andriy Kurilin |
rally: importance |
Undecided |
Low |
|
| 2016-01-05 05:39:41 |
OpenStack Infra |
keystone: status |
New |
Fix Released |
|
| 2016-01-05 17:09:14 |
OpenStack Infra |
rally: status |
Triaged |
Fix Released |
|
| 2016-01-05 17:37:25 |
LiuNanke |
bug task added |
|
gnocchi |
|
| 2016-01-05 17:37:32 |
LiuNanke |
gnocchi: status |
New |
In Progress |
|
| 2016-01-05 17:37:35 |
LiuNanke |
gnocchi: assignee |
|
LiuNanke (nanke-liu) |
|
| 2016-01-07 07:16:27 |
javeme |
bug task added |
|
oslo.messaging |
|
| 2016-01-08 05:33:49 |
OpenStack Infra |
oslo.messaging: status |
New |
In Progress |
|
| 2016-01-08 05:33:49 |
OpenStack Infra |
oslo.messaging: assignee |
|
javeme (javaloveme) |
|
| 2016-01-08 17:01:59 |
OpenStack Infra |
oslo.messaging: status |
In Progress |
Fix Released |
|
| 2016-01-11 09:40:54 |
Chaozhe Chen |
bug task added |
|
ceilometer |
|
| 2016-01-11 09:41:16 |
Chaozhe Chen |
bug task added |
|
cloudkitty |
|
| 2016-01-11 09:41:28 |
Chaozhe Chen |
cloudkitty: assignee |
|
Chaozhe Chen (chaozhe-chen) |
|
| 2016-01-11 09:41:31 |
Chaozhe Chen |
ceilometer: assignee |
|
Chaozhe Chen (chaozhe-chen) |
|
| 2016-01-12 12:11:02 |
caoyue |
bug task added |
|
neutron |
|
| 2016-01-12 12:11:16 |
caoyue |
neutron: assignee |
|
caoyue (yue-cao) |
|
| 2016-01-12 15:34:58 |
ting.wang |
bug task added |
|
heat |
|
| 2016-01-12 15:35:14 |
ting.wang |
heat: assignee |
|
tingwang (bx-wang) |
|
| 2016-01-12 15:37:25 |
ting.wang |
bug task added |
|
manila |
|
| 2016-01-12 15:42:33 |
ting.wang |
bug task added |
|
glance |
|
| 2016-01-12 15:43:03 |
ting.wang |
manila: assignee |
|
tingwang (bx-wang) |
|
| 2016-01-12 15:43:21 |
ting.wang |
glance: assignee |
|
tingwang (bx-wang) |
|
| 2016-01-12 15:49:58 |
ting.wang |
bug task added |
|
sahara |
|
| 2016-01-12 15:51:21 |
ting.wang |
bug task deleted |
sahara |
|
|
| 2016-01-12 15:59:36 |
ting.wang |
bug task added |
|
designate |
|
| 2016-01-12 15:59:51 |
ting.wang |
designate: assignee |
|
tingwang (bx-wang) |
|
| 2016-01-12 16:05:54 |
ting.wang |
bug task deleted |
glance |
|
|
| 2016-01-12 16:27:08 |
ting.wang |
bug task added |
|
watcher |
|
| 2016-01-12 16:27:25 |
ting.wang |
watcher: assignee |
|
tingwang (bx-wang) |
|
| 2016-01-13 02:31:41 |
caoyue |
neutron: status |
New |
In Progress |
|
| 2016-01-13 07:27:43 |
Kan |
bug |
|
|
added subscriber Kan |
| 2016-01-13 17:09:54 |
Tim Simmons |
designate: importance |
Undecided |
Medium |
|
| 2016-01-13 17:09:54 |
Tim Simmons |
designate: milestone |
|
mitaka-3 |
|
| 2016-01-13 17:10:13 |
Tim Simmons |
designate: status |
New |
Confirmed |
|
| 2016-01-14 01:50:06 |
Victor Ryzhenkin |
bug task added |
|
murano |
|
| 2016-01-14 01:50:52 |
Victor Ryzhenkin |
murano: importance |
Undecided |
Low |
|
| 2016-01-14 01:50:52 |
Victor Ryzhenkin |
murano: milestone |
|
mitaka-2 |
|
| 2016-01-14 01:51:48 |
Victor Ryzhenkin |
murano: assignee |
|
LiuNanke (nanke-liu) |
|
| 2016-01-14 01:52:05 |
Victor Ryzhenkin |
murano: status |
New |
In Progress |
|
| 2016-01-18 13:54:23 |
Antoine Cabot |
summary |
Make CONF.set_override with paramter enforce_type=True by default |
Make CONF.set_override with parameter enforce_type=True by default |
|
| 2016-01-18 13:55:14 |
Antoine Cabot |
watcher: importance |
Undecided |
Medium |
|
| 2016-01-18 13:55:14 |
Antoine Cabot |
watcher: milestone |
|
mitaka-3 |
|
| 2016-01-21 10:42:22 |
ting.wang |
manila: assignee |
tingwang (bx-wang) |
|
|
| 2016-01-21 23:28:46 |
Kirill Zaitsev |
murano: milestone |
mitaka-2 |
mitaka-3 |
|
| 2016-01-25 12:20:49 |
NidhiMittalHada |
manila: assignee |
|
NidhiMittalHada (nidhimittal19) |
|
| 2016-01-25 12:32:37 |
caoyue |
neutron: assignee |
caoyue (yue-cao) |
|
|
| 2016-02-02 16:28:37 |
David TARDIVEL |
watcher: status |
New |
Fix Released |
|
| 2016-02-05 15:01:40 |
ting.wang |
designate: assignee |
tingwang (bx-wang) |
|
|
| 2016-03-02 06:47:01 |
ChangBo Guo(gcb) |
murano: status |
In Progress |
Fix Released |
|
| 2016-03-02 06:50:23 |
ChangBo Guo(gcb) |
cloudkitty: status |
New |
Fix Released |
|
| 2016-03-02 06:50:56 |
ChangBo Guo(gcb) |
heat: assignee |
tingwang (bx-wang) |
|
|
| 2016-03-02 06:51:44 |
ChangBo Guo(gcb) |
neutron: status |
In Progress |
New |
|
| 2016-03-09 01:25:06 |
ChangBo Guo(gcb) |
bug task added |
|
cinder |
|
| 2016-03-09 01:44:47 |
OpenStack Infra |
cinder: status |
New |
In Progress |
|
| 2016-03-09 01:44:47 |
OpenStack Infra |
cinder: assignee |
|
ChangBo Guo(gcb) (glongwave) |
|
| 2016-03-09 13:37:47 |
Ihar Hrachyshka |
neutron: status |
New |
Won't Fix |
|
| 2016-03-10 13:35:47 |
gordon chung |
bug task deleted |
ceilometer |
|
|
| 2016-03-10 13:36:23 |
gordon chung |
bug task deleted |
gnocchi |
|
|
| 2016-03-10 16:47:05 |
Valeriy Ponomaryov |
manila: milestone |
|
newton-1 |
|
| 2016-03-10 21:35:42 |
Ben Swartzlander |
manila: importance |
Undecided |
Low |
|
| 2016-03-10 21:35:42 |
Ben Swartzlander |
manila: status |
New |
Triaged |
|
| 2016-03-30 18:32:15 |
Graham Hayes |
designate: status |
Confirmed |
Fix Released |
|
| 2016-03-31 06:35:51 |
Angus Salkeld |
heat: importance |
Undecided |
Low |
|
| 2016-03-31 06:35:51 |
Angus Salkeld |
heat: status |
New |
Confirmed |
|
| 2016-03-31 06:36:08 |
Angus Salkeld |
heat: assignee |
|
Angus Salkeld (asalkeld) |
|
| 2016-03-31 23:42:22 |
OpenStack Infra |
heat: status |
Confirmed |
In Progress |
|
| 2016-04-01 02:13:59 |
Steve Baker |
heat: milestone |
|
newton-1 |
|
| 2016-04-11 10:14:59 |
OpenStack Infra |
heat: status |
In Progress |
Fix Released |
|
| 2016-04-11 11:33:06 |
NidhiMittalHada |
manila: status |
Triaged |
In Progress |
|
| 2016-05-14 11:43:42 |
OpenStack Infra |
manila: status |
In Progress |
Fix Released |
|
| 2016-06-06 06:26:14 |
ChangBo Guo(gcb) |
bug task added |
|
nova |
|
| 2016-06-06 07:00:22 |
Pallavi |
nova: assignee |
|
Pallavi (pallavi-s) |
|
| 2016-06-06 07:14:13 |
Takashi Natsume |
tags |
|
oslo testing |
|
| 2016-06-06 07:17:13 |
Takashi Natsume |
nova: importance |
Undecided |
Low |
|
| 2016-06-06 07:17:13 |
Takashi Natsume |
nova: status |
New |
In Progress |
|
| 2016-06-12 05:23:27 |
OpenStack Infra |
oslo.config: status |
New |
In Progress |
|
| 2016-06-29 02:47:46 |
ChangBo Guo(gcb) |
bug task added |
|
glance |
|
| 2016-06-29 03:03:19 |
Ji.Wei |
glance: assignee |
|
Ji.Wei (jiwei) |
|
| 2016-07-06 07:28:40 |
ChangBo Guo(gcb) |
description |
1. Problems :
oslo_config provides method CONF.set_override[1] , developers usually use it to change config option's value in tests. That's convenient .
By default parameter enforce_type=False, it doesn't check any type or value of override. If set enforce_type=True , will check parameter
override's type and value. In production code(running time code), oslo_config always checks config option's value.
In short, we test and run code in different ways. so there's gap: config option with wrong type or invalid value can pass tests when
parameter enforce_type = False in consuming projects. that means some invalid or wrong tests are in our code base.
There is nova POC result when I enable "enforce_type=true" [2], and I must fix them in [3]
[1] https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L2173
[2] http://logs.openstack.org/16/242416/1/check/gate-nova-python27/97b5eff/testr_results.html.gz
[3] https://review.openstack.org/#/c/242416/ https://review.openstack.org/#/c/242717/ https://review.openstack.org/#/c/243061/
2. Proposal
1) Make method CONF.set_override with enforce_type=True in consuming projects. and fix violations when enforce_type=True in each project.
2) Make method CONF.set_override with enforce_type=True by default in oslo_config
Hope some one from consuming projects can help make enforce_type=True in consuming projects and fix violations,
You can find more details and comments in https://etherpad.openstack.org/p/enforce_type_true_by_default |
1. Problems :
oslo_config provides method CONF.set_override[1] , developers usually use it to change config option's value in tests. That's convenient .
By default parameter enforce_type=False, it doesn't check any type or value of override. If set enforce_type=True , will check parameter
override's type and value. In production code(running time code), oslo_config always checks config option's value.
In short, we test and run code in different ways. so there's gap: config option with wrong type or invalid value can pass tests when
parameter enforce_type = False in consuming projects. that means some invalid or wrong tests are in our code base.
There is nova POC result when I enable "enforce_type=true" [2], and I must fix them in [3]
[1] https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L2173
[2] http://logs.openstack.org/16/242416/1/check/gate-nova-python27/97b5eff/testr_results.html.gz
[3] https://review.openstack.org/#/c/242416/ https://review.openstack.org/#/c/242717/ https://review.openstack.org/#/c/243061/
2. Proposal
1) Fix violations when enforce_type=True in each project.
2) Make method CONF.set_override with enforce_type=True by default in oslo_config
You can find more details and comments in https://etherpad.openstack.org/p/enforce_type_true_by_default
3. How to find violations in your projects.
1. Run tox -e py27
2. then modify oslo.config with enforce_type=True
cd .tox/py27/lib64/python2.7/site-packages/oslo_config
edit cfg.py with enforec_type=True
--- cfg.py 2016-07-06 15:27:12.022446378 +0800
+++ cfg.py.back 2016-07-06 15:27:00.043439936 +0800
@@ -2390,7 +2390,7 @@
self._get_group(group)
@__clear_cache
- def set_override(self, name, override, group=None, enforce_type=False):
+ def set_override(self, name, override, group=None, enforce_type=True):
3. Run tox -e py27 again, you will find violations. |
|
| 2016-07-06 07:29:31 |
ChangBo Guo(gcb) |
description |
1. Problems :
oslo_config provides method CONF.set_override[1] , developers usually use it to change config option's value in tests. That's convenient .
By default parameter enforce_type=False, it doesn't check any type or value of override. If set enforce_type=True , will check parameter
override's type and value. In production code(running time code), oslo_config always checks config option's value.
In short, we test and run code in different ways. so there's gap: config option with wrong type or invalid value can pass tests when
parameter enforce_type = False in consuming projects. that means some invalid or wrong tests are in our code base.
There is nova POC result when I enable "enforce_type=true" [2], and I must fix them in [3]
[1] https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L2173
[2] http://logs.openstack.org/16/242416/1/check/gate-nova-python27/97b5eff/testr_results.html.gz
[3] https://review.openstack.org/#/c/242416/ https://review.openstack.org/#/c/242717/ https://review.openstack.org/#/c/243061/
2. Proposal
1) Fix violations when enforce_type=True in each project.
2) Make method CONF.set_override with enforce_type=True by default in oslo_config
You can find more details and comments in https://etherpad.openstack.org/p/enforce_type_true_by_default
3. How to find violations in your projects.
1. Run tox -e py27
2. then modify oslo.config with enforce_type=True
cd .tox/py27/lib64/python2.7/site-packages/oslo_config
edit cfg.py with enforec_type=True
--- cfg.py 2016-07-06 15:27:12.022446378 +0800
+++ cfg.py.back 2016-07-06 15:27:00.043439936 +0800
@@ -2390,7 +2390,7 @@
self._get_group(group)
@__clear_cache
- def set_override(self, name, override, group=None, enforce_type=False):
+ def set_override(self, name, override, group=None, enforce_type=True):
3. Run tox -e py27 again, you will find violations. |
1. Problems :
oslo_config provides method CONF.set_override[1] , developers usually use it to change config option's value in tests. That's convenient .
By default parameter enforce_type=False, it doesn't check any type or value of override. If set enforce_type=True , will check parameter
override's type and value. In production code(running time code), oslo_config always checks config option's value.
In short, we test and run code in different ways. so there's gap: config option with wrong type or invalid value can pass tests when
parameter enforce_type = False in consuming projects. that means some invalid or wrong tests are in our code base.
There is nova POC result when I enable "enforce_type=true" [2], and I must fix them in [3]
[1] https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L2173
[2] http://logs.openstack.org/16/242416/1/check/gate-nova-python27/97b5eff/testr_results.html.gz
[3] https://review.openstack.org/#/c/242416/ https://review.openstack.org/#/c/242717/ https://review.openstack.org/#/c/243061/
2. Proposal
1) Fix violations when enforce_type=True in each project.
2) Make method CONF.set_override with enforce_type=True by default in oslo_config
You can find more details and comments in https://etherpad.openstack.org/p/enforce_type_true_by_default
3. How to find violations in your projects.
1. Run tox -e py27
2. then modify oslo.config with enforce_type=True
cd .tox/py27/lib64/python2.7/site-packages/oslo_config
edit cfg.py with enforce_type=True
--- cfg.py 2016-07-06 15:27:12.022446378 +0800
+++ cfg.py.back 2016-07-06 15:27:00.043439936 +0800
@@ -2390,7 +2390,7 @@
self._get_group(group)
@__clear_cache
- def set_override(self, name, override, group=None, enforce_type=False):
+ def set_override(self, name, override, group=None, enforce_type=True):
3. Run tox -e py27 again, you will find violations. |
|
| 2016-07-07 07:54:05 |
ChangBo Guo(gcb) |
description |
1. Problems :
oslo_config provides method CONF.set_override[1] , developers usually use it to change config option's value in tests. That's convenient .
By default parameter enforce_type=False, it doesn't check any type or value of override. If set enforce_type=True , will check parameter
override's type and value. In production code(running time code), oslo_config always checks config option's value.
In short, we test and run code in different ways. so there's gap: config option with wrong type or invalid value can pass tests when
parameter enforce_type = False in consuming projects. that means some invalid or wrong tests are in our code base.
There is nova POC result when I enable "enforce_type=true" [2], and I must fix them in [3]
[1] https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L2173
[2] http://logs.openstack.org/16/242416/1/check/gate-nova-python27/97b5eff/testr_results.html.gz
[3] https://review.openstack.org/#/c/242416/ https://review.openstack.org/#/c/242717/ https://review.openstack.org/#/c/243061/
2. Proposal
1) Fix violations when enforce_type=True in each project.
2) Make method CONF.set_override with enforce_type=True by default in oslo_config
You can find more details and comments in https://etherpad.openstack.org/p/enforce_type_true_by_default
3. How to find violations in your projects.
1. Run tox -e py27
2. then modify oslo.config with enforce_type=True
cd .tox/py27/lib64/python2.7/site-packages/oslo_config
edit cfg.py with enforce_type=True
--- cfg.py 2016-07-06 15:27:12.022446378 +0800
+++ cfg.py.back 2016-07-06 15:27:00.043439936 +0800
@@ -2390,7 +2390,7 @@
self._get_group(group)
@__clear_cache
- def set_override(self, name, override, group=None, enforce_type=False):
+ def set_override(self, name, override, group=None, enforce_type=True):
3. Run tox -e py27 again, you will find violations. |
1. Problems :
oslo_config provides method CONF.set_override[1] , developers usually use it to change config option's value in tests. That's convenient .
By default parameter enforce_type=False, it doesn't check any type or value of override. If set enforce_type=True , will check parameter
override's type and value. In production code(running time code), oslo_config always checks config option's value.
In short, we test and run code in different ways. so there's gap: config option with wrong type or invalid value can pass tests when
parameter enforce_type = False in consuming projects. that means some invalid or wrong tests are in our code base.
[1] https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L2173
2. Proposal
1) Fix violations when enforce_type=True in each project.
2) Make method CONF.set_override with enforce_type=True by default in oslo_config
You can find more details and comments in https://etherpad.openstack.org/p/enforce_type_true_by_default
3. How to find violations in your projects.
1. Run tox -e py27
2. then modify oslo.config with enforce_type=True
cd .tox/py27/lib64/python2.7/site-packages/oslo_config
edit cfg.py with enforce_type=True
- def set_override(self, name, override, group=None, enforce_type=False):
+ def set_override(self, name, override, group=None, enforce_type=True):
3. Run tox -e py27 again, you will find violations. |
|
| 2016-08-09 07:19:20 |
OpenStack Infra |
nova: status |
In Progress |
Fix Released |
|
| 2016-08-31 08:59:14 |
Ji.Wei |
bug task added |
|
glance-store |
|
| 2016-08-31 08:59:33 |
Ji.Wei |
glance-store: assignee |
|
Ji.Wei (jiwei) |
|
| 2016-08-31 09:00:08 |
Ji.Wei |
bug task added |
|
ceilometer |
|
| 2016-08-31 09:02:29 |
Ji.Wei |
ceilometer: assignee |
|
Ji.Wei (jiwei) |
|
| 2016-08-31 09:21:47 |
Ji.Wei |
glance: status |
New |
Invalid |
|
| 2016-08-31 09:21:47 |
Ji.Wei |
glance: assignee |
Ji.Wei (jiwei) |
|
|
| 2016-08-31 09:26:09 |
Ji.Wei |
bug task added |
|
tacker |
|
| 2016-08-31 09:26:28 |
Ji.Wei |
tacker: assignee |
|
Ji.Wei (jiwei) |
|
| 2016-08-31 15:24:24 |
Ji.Wei |
bug task added |
|
freezer |
|
| 2016-08-31 15:25:59 |
Ji.Wei |
freezer: assignee |
|
Ji.Wei (jiwei) |
|
| 2016-09-01 00:17:39 |
OpenStack Infra |
tacker: status |
New |
In Progress |
|
| 2016-09-04 06:53:29 |
Hanxi Liu |
bug task added |
|
gnocchi |
|
| 2016-09-04 06:54:19 |
Hanxi Liu |
gnocchi: assignee |
|
Hanxi Liu (hanxi-liu) |
|
| 2016-09-05 01:24:57 |
OpenStack Infra |
ceilometer: status |
New |
In Progress |
|
| 2016-09-05 01:24:57 |
OpenStack Infra |
ceilometer: assignee |
Ji.Wei (jiwei) |
Hanxi Liu (hanxi-liu) |
|
| 2016-09-05 01:27:47 |
OpenStack Infra |
gnocchi: status |
New |
In Progress |
|
| 2016-09-05 01:37:46 |
Ji.Wei |
freezer: status |
New |
In Progress |
|
| 2016-09-05 01:38:29 |
Ji.Wei |
glance-store: status |
New |
In Progress |
|
| 2016-09-05 03:04:09 |
xiaozhuangqing |
bug task added |
|
panko |
|
| 2016-09-05 03:04:34 |
xiaozhuangqing |
panko: assignee |
|
xiaozhuangqing (xiaozhuangqing) |
|
| 2016-09-05 03:05:22 |
xiaozhuangqing |
bug task added |
|
aodh |
|
| 2016-09-05 03:05:44 |
xiaozhuangqing |
aodh: assignee |
|
xiaozhuangqing (xiaozhuangqing) |
|
| 2016-09-05 03:08:00 |
xiaozhuangqing |
aodh: status |
New |
In Progress |
|
| 2016-09-05 03:08:25 |
xiaozhuangqing |
panko: status |
New |
In Progress |
|
| 2016-09-05 03:27:05 |
Ji.Wei |
bug task added |
|
magnum |
|
| 2016-09-05 03:27:25 |
Ji.Wei |
magnum: assignee |
|
Ji.Wei (jiwei) |
|
| 2016-09-05 03:30:14 |
Ji.Wei |
bug task added |
|
quark |
|
| 2016-09-05 03:30:41 |
Ji.Wei |
quark: assignee |
|
Ji.Wei (jiwei) |
|
| 2016-09-05 03:31:27 |
Ji.Wei |
bug task added |
|
senlin |
|
| 2016-09-05 03:31:48 |
Ji.Wei |
senlin: assignee |
|
Ji.Wei (jiwei) |
|
| 2016-09-05 03:32:21 |
Ji.Wei |
bug task added |
|
ironic |
|
| 2016-09-05 03:32:39 |
Ji.Wei |
ironic: assignee |
|
Ji.Wei (jiwei) |
|
| 2016-09-05 03:45:21 |
Ji.Wei |
bug task added |
|
karbor |
|
| 2016-09-05 03:45:48 |
Ji.Wei |
karbor: assignee |
|
Ji.Wei (jiwei) |
|
| 2016-09-05 03:46:11 |
Ji.Wei |
bug task added |
|
octavia |
|
| 2016-09-05 03:46:55 |
Ji.Wei |
octavia: assignee |
|
Ji.Wei (jiwei) |
|
| 2016-09-05 03:47:24 |
Ji.Wei |
bug task added |
|
kolla |
|
| 2016-09-05 03:47:45 |
Ji.Wei |
kolla: assignee |
|
Ji.Wei (jiwei) |
|
| 2016-09-05 10:51:26 |
OpenStack Infra |
karbor: status |
New |
In Progress |
|
| 2016-09-05 12:14:18 |
Dmitry Tantsur |
ironic: importance |
Undecided |
Low |
|
| 2016-09-05 12:14:18 |
Dmitry Tantsur |
ironic: status |
New |
Triaged |
|
| 2016-09-06 03:29:24 |
OpenStack Infra |
karbor: status |
In Progress |
Fix Released |
|
| 2016-09-06 09:08:11 |
OpenStack Infra |
magnum: status |
New |
In Progress |
|
| 2016-09-15 20:42:02 |
Julien Danjou |
bug task deleted |
panko |
|
|
| 2016-09-21 20:17:46 |
Julien Danjou |
bug task deleted |
gnocchi |
|
|
| 2016-09-27 02:17:32 |
OpenStack Infra |
senlin: status |
New |
Fix Released |
|
| 2016-10-18 21:20:51 |
Michael Johnson |
octavia: importance |
Undecided |
Low |
|
| 2016-11-02 14:27:54 |
gordon chung |
bug task deleted |
ceilometer |
|
|
| 2016-11-02 14:32:11 |
gordon chung |
bug task deleted |
aodh |
|
|
| 2016-11-11 10:22:40 |
Tammy Miller |
bug |
|
|
added subscriber Tammy Miller |
| 2016-11-24 12:39:23 |
Paul Bourke |
kolla: importance |
Undecided |
Low |
|
| 2016-11-24 12:39:23 |
Paul Bourke |
kolla: status |
New |
Confirmed |
|
| 2016-12-16 07:10:16 |
Jeffrey Zhang |
kolla: milestone |
|
ocata-3 |
|
| 2017-01-30 14:40:33 |
Ian Cordasco |
bug task deleted |
glance-store |
|
|
| 2017-04-10 04:19:05 |
OpenStack Infra |
oslo.config: status |
In Progress |
Fix Released |
|
| 2017-04-12 08:32:12 |
Luigi Toscano |
bug task added |
|
tempest |
|
| 2017-04-12 08:41:29 |
Luigi Toscano |
tempest: status |
New |
Confirmed |
|
| 2017-04-13 04:54:48 |
OpenStack Infra |
tempest: status |
Confirmed |
In Progress |
|
| 2017-04-13 04:54:48 |
OpenStack Infra |
tempest: assignee |
|
ChangBo Guo(gcb) (glongwave) |
|
| 2017-04-13 11:09:16 |
OpenStack Infra |
tempest: status |
In Progress |
Fix Released |
|
| 2017-04-18 12:32:29 |
OpenStack Infra |
ironic: status |
Triaged |
In Progress |
|
| 2017-04-18 12:32:29 |
OpenStack Infra |
ironic: assignee |
Ji.Wei (jiwei) |
Javier Peña (jpena-c) |
|
| 2017-04-21 00:28:18 |
OpenStack Infra |
ironic: status |
In Progress |
Fix Released |
|
| 2017-05-31 07:04:01 |
ChangBo Guo(gcb) |
description |
1. Problems :
oslo_config provides method CONF.set_override[1] , developers usually use it to change config option's value in tests. That's convenient .
By default parameter enforce_type=False, it doesn't check any type or value of override. If set enforce_type=True , will check parameter
override's type and value. In production code(running time code), oslo_config always checks config option's value.
In short, we test and run code in different ways. so there's gap: config option with wrong type or invalid value can pass tests when
parameter enforce_type = False in consuming projects. that means some invalid or wrong tests are in our code base.
[1] https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L2173
2. Proposal
1) Fix violations when enforce_type=True in each project.
2) Make method CONF.set_override with enforce_type=True by default in oslo_config
You can find more details and comments in https://etherpad.openstack.org/p/enforce_type_true_by_default
3. How to find violations in your projects.
1. Run tox -e py27
2. then modify oslo.config with enforce_type=True
cd .tox/py27/lib64/python2.7/site-packages/oslo_config
edit cfg.py with enforce_type=True
- def set_override(self, name, override, group=None, enforce_type=False):
+ def set_override(self, name, override, group=None, enforce_type=True):
3. Run tox -e py27 again, you will find violations. |
1. Problems :
oslo_config provides method CONF.set_override[1] , developers usually use it to change config option's value in tests. That's convenient .
By default parameter enforce_type=False, it doesn't check any type or value of override. If set enforce_type=True , will check parameter
override's type and value. In production code(running time code), oslo_config always checks config option's value.
In short, we test and run code in different ways. so there's gap: config option with wrong type or invalid value can pass tests when
parameter enforce_type = False in consuming projects. that means some invalid or wrong tests are in our code base.
[1] https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L2173
2. Proposal
1) Fix violations when enforce_type=True in each project.
2) Make method CONF.set_override with enforce_type=True by default in oslo_config
You can find more details and comments in https://etherpad.openstack.org/p/enforce_type_true_by_default
3. How to find violations in your projects.
1. Run tox -e py27
2. then modify oslo.config with enforce_type=True
cd .tox/py27/lib64/python2.7/site-packages/oslo_config
edit cfg.py with enforce_type=True
- def set_override(self, name, override, group=None, enforce_type=False):
+ def set_override(self, name, override, group=None, enforce_type=True):
3. Run tox -e py27 again, you will find violations.
The current state is that oslo.config make enforce_type as True by default and deprecate this parameter, will remove it in the future, the current work
is that remove usage of enforce_type in consuming projects. We can list the
usage of it in http://codesearch.openstack.org/?q=enforce_type&i=nope&files=&repos= |
|
| 2018-02-20 06:17:44 |
Nguyen Hai |
tacker: status |
In Progress |
Fix Released |
|
| 2018-03-05 08:41:22 |
Ji.Wei |
freezer: status |
In Progress |
Fix Committed |
|
| 2018-03-05 08:41:47 |
Ji.Wei |
quark: assignee |
Ji.Wei (jiwei) |
|
|
| 2018-03-05 08:42:20 |
Ji.Wei |
magnum: status |
In Progress |
Fix Released |
|
| 2018-03-05 08:42:33 |
Ji.Wei |
magnum: assignee |
Ji.Wei (jiwei) |
|
|
| 2018-03-05 08:43:05 |
Ji.Wei |
kolla: assignee |
Ji.Wei (jiwei) |
|
|
| 2018-03-05 08:43:54 |
Ji.Wei |
octavia: assignee |
Ji.Wei (jiwei) |
|
|
| 2018-04-19 01:40:17 |
Jeffrey Zhang |
kolla: importance |
Low |
Undecided |
|
| 2018-04-19 01:40:17 |
Jeffrey Zhang |
kolla: status |
Confirmed |
Expired |
|
| 2023-03-31 08:29:32 |
Gregory Thiemonge |
octavia: status |
New |
Invalid |
|
| 2023-03-31 08:29:41 |
Gregory Thiemonge |
tags |
oslo testing |
auto-abandon oslo testing |
|
