cache invalidation fails for endpoint filter extension

Bug #1516468 reported by Dave Chen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Dave Chen

Bug Description

With the patch [1] got merged, keystone has the ablity to cache catalog/v3 catalog, and will invalidate the cache when there is any changes about the catalog, i.e. add_endpoint_to_project, remove_endpoint_from_project. But the testcase was missed there, this means there is no testcase covered in keystone even the API in the Manager layer was not defined correctly [2].

The bug will focus on `add_endpoint_to_project` and `remove_endpoint_from_project` and leave `add_endpoint_group_to_project`
and `remove_endpoint_group_from_project` as it is, this is beacuse these two API should impact the endpoints in theory but it's not in practice. So, add some testcase to test its impact on catalog is impossible. There should be anothor bug filed [3] and testcase will be added when that bug was fixed.

[1] https://review.openstack.org/#/c/215212/
[2] https://review.openstack.org/#/c/243951/
[3] https://bugs.launchpad.net/keystone/+bug/1516469

Dave Chen (wei-d-chen)
description: updated
Changed in keystone:
assignee: nobody → Dave Chen (wei-d-chen)
Dave Chen (wei-d-chen)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/245633

Changed in keystone:
status: New → In Progress
Changed in keystone:
importance: Undecided → Medium
summary: - miss the testcase for caching to get_catalog/get_v3_catalog in endpoint
- filter extension
+ cache invalidation fails for endpoint filter extension
Changed in keystone:
assignee: Dave Chen (wei-d-chen) → Steve Martinelli (stevemar)
Revision history for this message
Steve Martinelli (stevemar) wrote :
Changed in keystone:
assignee: Steve Martinelli (stevemar) → Dave Chen (wei-d-chen)
milestone: none → mitaka-1
Changed in keystone:
assignee: Dave Chen (wei-d-chen) → Steve Martinelli (stevemar)
Revision history for this message
Dave Chen (wei-d-chen) wrote :

Steve - Really appreciate for updating the desc.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/243951
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=b51521a95155eb5c8fb3756f0188efc1ba55b5b5
Submitter: Jenkins
Branch: master

commit b51521a95155eb5c8fb3756f0188efc1ba55b5b5
Author: Dave Chen <email address hidden>
Date: Wed Nov 11 12:49:13 2015 +0800

    Fix the wrong method name

    The correct method name should be `remove_endpoint_from_project`
    according to the definition in the controller layer or the name
    of abstract method.

    Partial-Bug: 1516468

    Change-Id: I891a59969bcbbe5cc91a0dca3b8f1f253b93bcbc

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/245633
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=0bad37f82cbda03b715675cc5770a3a258e7224e
Submitter: Jenkins
Branch: master

commit 0bad37f82cbda03b715675cc5770a3a258e7224e
Author: Dave Chen <email address hidden>
Date: Mon Nov 16 12:35:12 2015 +0800

    Add testcases to check cache invalidation in endpoint filter extension

    keystone now has the ability to cache catalog, and will invalidate
    the cache when there is any change about the catalog, i.e. add endpoints
    to project or remove endpoints from project. But the testcase was missed.

    The patch focus on endpoint project association and leave endpoint_group
    project association as it is. since these two APIs should impact the
    endpoints in theory but it's doesnot in practice. So, add some testcases
    to test its impact on catalog is impossible.

    There is another bug filed [1] and testcases for endpoint group will be
    added when that bug is fixed.

    [1] https://bugs.launchpad.net/keystone/+bug/1516469

    Change-Id: Ie85679111e0f8b9d00e11155594db391eb92c09f
    Closes-Bug: #1516468

Changed in keystone:
status: In Progress → Fix Committed
Dave Chen (wei-d-chen)
Changed in keystone:
assignee: Steve Martinelli (stevemar) → Dave Chen (wei-d-chen)
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/keystone 9.0.0.0b1

This issue was fixed in the openstack/keystone 9.0.0.0b1 development milestone.

Changed in keystone:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to keystone (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/258785

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to keystone (master)

Reviewed: https://review.openstack.org/258785
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=76436415d7085e8d32ee9030a14070ac4c5ccf0c
Submitter: Jenkins
Branch: master

commit 76436415d7085e8d32ee9030a14070ac4c5ccf0c
Author: Dave Chen <email address hidden>
Date: Thu Dec 17 11:37:27 2015 +0800

    Add testcases to check cache invalidation

    keystone now has the ability to cache catalog, and will invalidate
    the cache when there is any change about the catalog, i.e. add endpoint
    group to project, but the testcase was missed.

    Since the bug #1516469 has been fixed, any change about endpoint_group
    project association should invalidate the catalog cache as well.

    The patch provide the testcases to test that cache has been invalidated if
    there is any change about endpoint_group project association

    Change-Id: I80c87ef834da9dde2e6ad1cc2b749822fda1fa79
    Related-Bug: #1516468

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.